Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/utils/example-imports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ export async function resolveExampleWorkspaceImports(
for (const group of resolvedGroups) {
for (const peerPackage of group.peerPackages) {
if (
!peerPackage.startsWith('@types/') &&
packageVersions.has(peerPackage) &&
!resolvedPackageNames.has(peerPackage) &&
!hasWorkspacePackageImport(workspaceImports, peerPackage)
Expand Down
14 changes: 11 additions & 3 deletions tests/example-imports.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ test('externalizes complete explicit peers that source code does not import', as
})
})

test('resolves declared peers that source code does not import', async () => {
test('resolves declared runtime peers but ignores type-only peers', async () => {
const workspace = createExampleWorkspace({
entry: '/index.ts',
files: {
Expand All @@ -309,16 +309,20 @@ test('resolves declared peers that source code does not import', async () => {
'@example/ui': '3.2.1',
react: '18.3.1',
},
devDependencies: { '@types/react': '18.3.1' },
}),
},
})
const requests: Array<string> = []
const metadataFetch = createMetadataFetch(
[],
requests,
(url) => ({
version: url.includes('@example/ui') ? '3.2.1' : '18.3.1',
}),
(url): Record<string, string> =>
url.includes('@example/ui') ? { react: '^18.0.0' } : {},
url.includes('@example/ui')
? { '@types/react': '>=18.0.0', react: '^18.0.0' }
: {},
)

const imports = await resolveExampleWorkspaceImports(
Expand All @@ -333,6 +337,10 @@ test('resolves declared peers that source code does not import', async () => {
react: 'https://esm.sh/react@18.3.1',
'react/': 'https://esm.sh/react@18.3.1/',
})
assert.equal(
requests.some((url) => url.includes('@types/react')),
false,
)
})

test('stops before resolving packages when already aborted', async () => {
Expand Down