fix: RecentPostsWidget TypeError with non-array posts - #1185
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 5a29fad | Commit Preview URL Branch Preview URL |
Aug 27 2026, 11:04 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: r.map is not a functionoccurring in theRecentPostsWidgetwhen thefetchRecentPostsserver function returns a non-array value (e.g., an error object).Changes Made:
src/components/RecentPostsWidget.tsx: Modified the conditional rendering logic fromif (!visiblePosts)toif (!Array.isArray(visiblePosts)). This ensures that iffetchRecentPostsresolves to a non-array value (like an error object), the component correctly renders theRecentPostsSkeletoninstead of attempting to call.map()on an invalid type, which caused the crash.src/utils/blog.functions.ts: Wrapped the body of thefetchRecentPostshandler in atry/catchblock. In case of any error during post fetching, it now returns an empty array ([]). This provides a more robust server function that guarantees an array return type, preventing non-array payloads from ever reaching the client-side components.Why these changes?
The original issue stemmed from
fetchRecentPostspotentially returning an object (e.g.,{ error: "..." }) on failure. TheRecentPostsWidget's guard!visiblePostswas insufficient as an object is truthy, andobject.lengthisundefined, bypassing the check. Consequently,RecentPostsListreceived a non-array and crashed when calling.map(). These changes implement a more precise type check in the widget and a safer return value from the server function, resolving theTypeErrorand improving resilience.Fixes TANSTACK-COM-4SC
This PR was automatically generated by Sentry. You can adjust this setting at any time.