feat(ds): propagate palette, extract MegaMenuItem, expand /ds pages#1033
feat(ds): propagate palette, extract MegaMenuItem, expand /ds pages#1033Abeuty wants to merge 5 commits into
Conversation
Design-system follow-ups on top of the rebrand: - Palette: bridge legacy gray/twine to the warm DS neutral ramp in app.css so the whole site adopts the new palette; migrate the shared primitives (Button, Badge, FormInput, Tooltip) to semantic tokens. - Typography: add semantic .h1-.h6 classes; move Font families to the top of /ds/typography and make the family cards minimal. - MegaMenuItem: extract the mega-menu row into a reusable component matched to the Figma "Mega Menu Item" (bordered 44px icon, Bricolage-bold title, #aba594 description, adaptive hover/press); wire it into the Navbar with 8px spacing between items. - /ds/navbar: new Navbar DS page - anatomy preview with a device-size toggle (Auto/Mobile/iPad/Desktop) driven by container queries, plus a MegaMenuItem showcase. Add a "Design System" nav item under Support. - Home: remove the "Browse the stack" section; restructure "Why TanStack" into four centered principle sections. Refine navbar spacing. - Icons: finish the lucide->Phosphor migration (CheckCircleIcon->CheckCircle, CogsIcon->Gear); remove the orphaned custom icons. - Spinner: remove the Palm spinner demo from /ds/spinner. - Add @figma/code-connect dev dependency. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bump the shared DsPage wrapper from max-w-5xl (1024px) to max-w-7xl (1280px) so all design-system pages use more horizontal space on wide screens (e.g. the icon-migration grid no longer truncates names). Header stays left-aligned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 4908ce2 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 05:53 PM |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve conflicts with the updated base: - pnpm-lock.yaml: regenerated from the merged package.json (keeps @figma/ code-connect plus the base's new deps). - app.css: the base added a :root/:host block pinning grays to the original cool values (a layer-stability fix); updated it to the warm DS-neutral bridge values so the palette shift isn't reverted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
…ds-rebrand-followups # Conflicts: # src/routes/index.tsx
|
Marking these as acceptable — they're false-positive "obfuscated code" flags on legitimate (minified) transitive @SocketSecurity ignore npm/data-urls@5.0.0 🤖 Addressed by Claude Code |
…ds-rebrand-followups # Conflicts: # src/routes/index.tsx # src/routes/workshops.tsx
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Design-system follow-ups stacked on the rebrand branch (
ds-rebrand-phosphor-icons). Targets that branch, notmain, so the diff stays focused on this work rather than re-including the rebrand commit.What changed
Color palette propagation
--color-gray-*/--color-twine-*scale to the warm DS neutral ramp inapp.css, so the whole site adopts the new palette with zero component edits (anchored to the DS neutral steps, lightness preserved across all 11 for contrast, works in light + dark).Button,Badge,FormInput,Tooltip— to semantic tokens (text-text-*,bg-background-*,border-border-*), shedding their hardcodeddark:pairs.MegaMenuItem (new component)
src/components/MegaMenuItem.tsx, matched to the Figma "Mega Menu Item" (44px bordered icon, Bricolage-boldheading-5title,#aba594body-xsdescription, mode-adaptive hover/press).MenuItemLinknow delegates to it (all mega menus updated), with a standard 8px gap between items.twMergebug that was silently dropping the description color./ds pages
/ds/navbarpage: navbar anatomy with a device-size toggle (Auto / Mobile / iPad / Desktop) driven by container queries + scale-to-fit, plus a MegaMenuItem showcase.max-w-5xl→max-w-7xl), header stays left-aligned..h1–.h6classes; move Font families to the top and slim the cards./ds/spinner.Home + icon cleanup
CheckCircleIcon→CheckCircle,CogsIcon→Gear) and delete the orphaned custom icons.Tooling
@figma/code-connectdev dependency.Notes for reviewers
ds-rebrand-phosphor-icons. Merge/rebase that first, or retarget tomainonly after the rebrand lands.MegaMenuItemdescription usestext-text-secondary(exact Figma#aba594in dark); it resolves darker in light mode — easy to switch totext-text-mutedif preferred.tsc,oxlint(0/0), unit tests (12/12).🤖 Generated with Claude Code