chore(oxfmt.config): replace '.oxfmtrc.json' with 'oxfmt.config.ts' by sukvvon · Pull Request #11944 · TanStack/query

sukvvon · 2026-10-09T17:11:13Z

🎯 Changes

Move the oxfmt config to TypeScript, in line with oxlint.config.ts.

Replace .oxfmtrc.json with oxfmt.config.ts using defineConfig, with the same options and ignore patterns. $schema is dropped because defineConfig provides the types. oxfmt discovers oxfmt.config.ts on its own.
scripts/generate-labeler-config.ts imports the config instead of reading and parsing .oxfmtrc.json.

oxfmt --check . passes on the same set of files as before, and the generated labeler config is identical.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Moved formatting settings into a TypeScript configuration.
- Updated labeler configuration generation to use the shared formatting settings.

changeset-bot · 2026-10-09T17:11:22Z

⚠️ No Changeset found

Latest commit: 75a7724

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-09T17:11:53Z

View your CI Pipeline Execution ↗ for commit 75a7724

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 20s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-09 17:14:53 UTC

coderabbitai · 2026-10-09T17:13:03Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: 95ac055e-e1a4-4328-bb09-504812ebbb17

📥 Commits

Reviewing files that changed from the base of the PR and between a8163e0 and 75a7724.

📒 Files selected for processing (3)

.oxfmtrc.json
oxfmt.config.ts
scripts/generate-labeler-config.ts

💤 Files with no reviewable changes (1)

.oxfmtrc.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

The formatter configuration moved from .oxfmtrc.json to oxfmt.config.ts. The labeler generation script now imports the TypeScript configuration instead of reading and validating the JSON file at runtime.

Changes

Oxfmt Configuration Migration

Layer / File(s)	Summary
Define and use the TypeScript formatter configuration `.oxfmtrc.json`, `oxfmt.config.ts`, `scripts/generate-labeler-config.ts`	The TypeScript configuration defines formatting options and ignore patterns. The script imports it instead of reading, validating, and logging the JSON configuration path.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: alemtuzlak

Merge Risk: ⚪ Minimal · up to 75a77

The formatter configuration retains its prior behavior, and no concrete formatter or labeler-generation failure is established. The change is ready for normal merge checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: replacing .oxfmtrc.json with oxfmt.config.ts.
Description check		The description explains the configuration migration, identifies the script update, reports validation results, and completes all required checklist and release-impact sections.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-09T17:14:17Z

🚀 Changeset Version Preview

2 package(s) bumped directly, 23 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.104.1 → 5.104.2	Changeset
`@tanstack/vue-query`	5.104.1 → 5.104.2	Changeset
`@tanstack/angular-query-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/angular-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/eslint-plugin-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/lit-query`	0.2.26 → 0.2.27	Dependent
`@tanstack/preact-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/preact-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-async-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-broadcast-client-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-persist-client-core`	5.104.1 → 5.104.2	Dependent
`@tanstack/query-sync-storage-persister`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-next-experimental`	5.104.1 → 5.104.2	Dependent
`@tanstack/react-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-devtools`	5.104.1 → 5.104.2	Dependent
`@tanstack/solid-query-persist-client`	5.104.1 → 5.104.2	Dependent
`@tanstack/svelte-query`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-devtools`	6.3.1 → 6.3.2	Dependent
`@tanstack/svelte-query-persist-client`	6.3.1 → 6.3.2	Dependent
`@tanstack/vue-query-devtools`	6.3.1 → 6.3.2	Dependent

pkg-pr-new · 2026-10-09T17:14:28Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11944

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11944

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11944

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11944

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11944

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11944

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11944

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11944

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11944

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11944

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11944

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11944

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11944

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11944

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11944

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11944

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11944

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11944

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11944

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11944

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11944

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11944

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11944

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11944

commit: 75a7724

github-actions · 2026-10-09T17:14:37Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(oxfmt.config): replace '.oxfmtrc.json' with 'oxfmt.config.ts'

75a7724

sukvvon requested a review from a team as a code owner October 9, 2026 17:11

sukvvon self-assigned this Oct 9, 2026

schiller-manuel approved these changes Oct 9, 2026

View reviewed changes

sukvvon merged commit a2e0eb2 into main Oct 10, 2026
9 checks passed

sukvvon deleted the chore/oxfmt-config-ts branch October 10, 2026 01:08

Navigation Menu

Repository navigation

chore(oxfmt.config): replace '.oxfmtrc.json' with 'oxfmt.config.ts' - #11944

chore(oxfmt.config): replace '.oxfmtrc.json' with 'oxfmt.config.ts'#11944
sukvvon merged 1 commit into
mainfrom
chore/oxfmt-config-ts

sukvvon commented Oct 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 9, 2026

Uh oh!

nx-cloud Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

pkg-pr-new Bot commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sukvvon commented Oct 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 9, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Oct 9, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 9, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Oct 9, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 9, 2026 •

edited

Loading

coderabbitai Bot commented Oct 9, 2026 •

edited

Loading