feat(query-core): allow overriding dehydration timestamp 🤖🤖🤖 - #11395
Draft
aurorascharff wants to merge 1 commit into
Draft
feat(query-core): allow overriding dehydration timestamp 🤖🤖🤖#11395aurorascharff wants to merge 1 commit into
aurorascharff wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit a97345f
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Next.js Cache Components cannot prerender
dehydrate()becausedehydrateQuery()readsDate.now().The Next.js client-side fetching guide works around this by caching a timestamp with the same tags as the data, then manually mapping the query cache into a
DehydratedState:This PR adds
dehydratedAttoDehydrateOptions, so applications can use the normal dehydration logic instead:The caller is still responsible for keeping the timestamp in the same cache lifecycle as the data. When omitted,
dehydratedAtcontinues to default toDate.now().Includes tests, documentation, and a query-core changeset. Related to #9457.
✅ Checklist
pnpm run test:pr, or does not applyLocal verification passed for query-core tests, its TypeScript matrix, lint, package build, formatting, and documentation links. The only remaining repository-wide failure was a Next.js example whose build-time PokeAPI request is unavailable in the restricted environment.
🚀 Release Impact