fix(solid-query): prevent lost updates when mounting cached queries - #11385
Draft
2wheeh wants to merge 3 commits into
Draft
fix(solid-query): prevent lost updates when mounting cached queries#113852wheeh wants to merge 3 commits into
2wheeh wants to merge 3 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2wheeh
marked this pull request as ready for review
September 3, 2026 16:22
2wheeh
marked this pull request as draft
September 3, 2026 16:22
2wheeh
force-pushed
the
fix/solid-query-mount-notification
branch
from
September 4, 2026 02:43
19cd3f3 to
518c5c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11384
🎯 Changes
Fixes a Solid Query timing issue where updates could be lost when a cached query refetched during mount.
Observer attachment is deferred until the conditional subtree is ready, while the optimistic fetch status remains available synchronously. Regression tests cover the behavior in both browser and semantic tests.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact