Skip to content

fix(solid-query): prevent lost updates when mounting cached queries - #11385

Draft
2wheeh wants to merge 3 commits into
TanStack:solid-query-v6-prefrom
2wheeh:fix/solid-query-mount-notification
Draft

fix(solid-query): prevent lost updates when mounting cached queries#11385
2wheeh wants to merge 3 commits into
TanStack:solid-query-v6-prefrom
2wheeh:fix/solid-query-mount-notification

Conversation

@2wheeh

@2wheeh 2wheeh commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

fixes #11384

🎯 Changes

Fixes a Solid Query timing issue where updates could be lost when a cached query refetched during mount.

Observer attachment is deferred until the conditional subtree is ready, while the optimistic fetch status remains available synchronously. Regression tests cover the behavior in both browser and semantic tests.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@2wheeh
2wheeh marked this pull request as ready for review September 3, 2026 16:22
@2wheeh
2wheeh marked this pull request as draft September 3, 2026 16:22
@2wheeh
2wheeh force-pushed the fix/solid-query-mount-notification branch from 19cd3f3 to 518c5c7 Compare September 4, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant