Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-fields-revalidate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/form-core': patch
---

Set `isValidating` on every async field validation run, not only the first one.
1 change: 1 addition & 0 deletions packages/form-core/src/FieldApi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1513,6 +1513,7 @@ export class FieldApi<

field.timeoutIds.validations[validateObj.cause] = setTimeout(
async () => {
field.timeoutIds.validations[validateObj.cause] = null
if (controller.signal.aborted) return rawResolve(undefined)
try {
rawResolve(
Expand Down
40 changes: 40 additions & 0 deletions packages/form-core/tests/FieldApi.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,46 @@ describe('field api', () => {
storeunsub()
})

it('should set isValidating on every async validation run', async () => {
// Test for https://github.com/TanStack/form/issues/2372
vi.useFakeTimers()

const form = new FormApi({
defaultValues: {
name: '',
},
})

form.mount()

const field = new FieldApi({
form,
name: 'name',
validators: {
onChangeAsync: async ({ value }) => {
await sleep(1000)
return value === 'admin' ? 'Username is already taken' : undefined
},
},
})

field.mount()

field.setValue('admin')
await vi.advanceTimersByTimeAsync(0)
expect(field.getMeta().isValidating).toBe(true)
await vi.runAllTimersAsync()
expect(field.getMeta().isValidating).toBe(false)
expect(field.getMeta().errors).toStrictEqual(['Username is already taken'])

field.setValue('asdf')
await vi.advanceTimersByTimeAsync(0)
expect(field.getMeta().isValidating).toBe(true)
await vi.runAllTimersAsync()
expect(field.getMeta().isValidating).toBe(false)
expect(field.getMeta().errors).toStrictEqual([])
})

it('should run async validation onChange', async () => {
vi.useFakeTimers()

Expand Down