Skip to content

[v2] Perf: Use one atom subscription per Field #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scttcper wants to merge 1 commit into
base: alpha
Choose a base branch
from
+5 −7
Open

[v2] Perf: Use one atom subscription per Field #2358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/react-form/src/ReactForm/fieldSubscriptions.lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@ import type { AnyInternalFieldApi } from '@tanstack/form-core/internals'
export function useValueFieldSubscription(
fieldApi: AnyInternalFieldApi,
): AnyInternalFieldApi {
const value = useSelector(fieldApi.atom, (state) => state.value)
const meta = useSelector(fieldApi.atom, (state) => state.meta)
const state = useSelector(fieldApi.atom)

return useMemo(() => {
void meta
void value
void state
return Object.create(fieldApi)
}, [fieldApi, meta, value])
}, [fieldApi, state])
}

export function useArrayFieldSubscription(
Expand Down
4 changes: 2 additions & 2 deletions packages/react-form/tests/FormGroup.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ describe('FormGroup', () => {
expect(getByTestId('app-field-name')).toHaveTextContent('guestDetails.name')
})

it('uses the AppForm field provider subscription for field context', async () => {
it('uses one AppForm field provider subscription for field context', async () => {
const subscribe = vi.fn()
const unsubscribe = vi.fn()
const instrumentedAtoms = new WeakSet<object>()
Expand Down Expand Up @@ -169,7 +169,7 @@ describe('FormGroup', () => {

await vi.waitFor(() => {
expect(subscribe.mock.calls.length - unsubscribe.mock.calls.length).toBe(
2,
1,
)
})

Expand Down