[v2] Fix: Keep ArrayField in sync after array replacement - #2356
Open
scttcper wants to merge 1 commit into
Open
Conversation
Replacing an array with another array of the same length updated form state without rerendering ArrayField. Bump the shared array version for direct replacements while keeping nested field updates isolated. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
scttcper
commented
Aug 24, 2026
| expect(input).toHaveValue('new-value') | ||
| }) | ||
|
|
||
| it('rerenders an ArrayField for a same-length replacement', () => { |
Author
There was a problem hiding this comment.
this test does fail without the change
scttcper
marked this pull request as ready for review
August 24, 2026 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayFieldonly reacts to array length and_arrayVersion, so replacing an array with a different array of the same length updated form state without rerendering the array container. UI rendered from the array could stay stale while submission used the new values.This bumps
_arrayVersionfor direct same-length replacements. Array helpers now rely on length changes or this shared behavior instead of manually updating the version, while nested field updates still avoid rerendering the parentArrayField.