Repository navigation
fix(query-db): compose accepted ownership before publication - #2198
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: de1ea0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title is concise, specific, and accurately describes the main ownership-composition fix. Description check The description provides detailed motivation, cause, repair, oracle coverage, and verification results. It does not use the template headings or include the required Checklist and Release Impact secti… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description provides detailed motivation, cause, repair, oracle coverage, and verification results. It does not use the template headings or include the required Checklist and Release Impact sections, but the substantive information is mostly complete.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
|
Size Change: 0 B Total Size: 218 kB ℹ️ View Unchanged
|
More templates
@tanstack/angular-db
@tanstack/browser-db-sqlite-persistence
@tanstack/capacitor-db-sqlite-persistence
@tanstack/cloudflare-durable-objects-db-sqlite-persistence
@tanstack/db
@tanstack/db-ivm
@tanstack/db-sqlite-persistence-core
@tanstack/electric-db-collection
@tanstack/electron-db-sqlite-persistence
@tanstack/expo-db-sqlite-persistence
@tanstack/node-db-sqlite-persistence
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/react-native-db-sqlite-persistence
@tanstack/react-router-with-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/tauri-db-sqlite-persistence
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Merged
Contributor
|
🎉 This PR has been released! Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
An ordered refetch could retain a backend-absent row after another Query observed that row. The failure required an optimistic mutation to delay publication.
PR #2030 introduced the accepted-before-publication interval. PR #2154 exposed the regression through its ordered-prefix oracle.
The failing CI replay showed the concrete result. The ordered window disagreed with the backend after publication resumed.
Cause
The Query ownership indexes accepted newer results before the Collection published their metadata. Cleanup could then rebuild ownership from older published metadata.
That stale metadata could restore an owner that an accepted result retired. An older cleanup could also invalidate ownership from a later reacquisition.
The same authority problem made cold restore depend on row order. Processing one row could make a partially rebuilt Query appear fully resolved.
Repair
Resolved Query ownership now takes precedence over persisted ownership. Persisted metadata seeds only Queries that do not yet have a resolved ownership result.
Each accepted result installs a new ownership generation. Cleanup removes its accepted edges immediately and keeps an empty tombstone until publication completes.
The tombstone retires only when it still belongs to that cleanup. Therefore, an older cleanup cannot invalidate a later acquisition.
Cold persisted and hydrated rows project their owners before they update the ownership indexes. This makes reconstruction independent of row order.
This repair reuses the existing ownership indexes. Production source changes by 54 additions and 60 deletions.
Excluding comments and blank lines, production code changes by 49 additions and 53 deletions.
Oracle model
The ownership oracle does not copy the production maps or cleanup algorithm. Its model stores each active Query's latest complete result.
The expected public Collection is the union of those results. The histories compare that model with public rows and durable effects at defined checkpoints.
New histories cover these cases:
The oracle documentation records the covered histories and the remaining limits.
Verification
pnpm vitest run packages/query-db-collection/tests/ownership-lifecycle.oracle.test.ts packages/query-db-collection/tests/refetch-ordered-prefix-oracle.test.ts --pool-options.threads.maxThreads=2passed 379 tests.query-db.refetch-ordered-prefixCI replay passed with seed-1338032236and its recorded path.pnpm --filter @tanstack/query-db-collection buildpassed.git diff --checkpassed.Summary by CodeRabbit