Repository navigation
fix: restore type assertions a merge commit's lint fix removed - #2125
Merged
Merged
Conversation
The pre-commit `eslint --fix` on #2112's merge-from-main commit ran without a built `@tanstack/db`, so it lost the types that trailbase and query-db read from `dist` and removed non-null assertions, casts and two eslint-disable comments as unnecessary. CI builds first, where they are needed: the trailbase build and the query-db lint fail on main. Restore the four files to their versions before #2112. Co-authored-by: Isaac <no-reply@databricks.com>
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: restoring type assertions removed by a merge commit's lint fix. Description check The description includes the required Changes, Checklist, and Release Impact sections. It explains the failure, cause, fix, test status, and release impact. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
More templates
@tanstack/angular-db
@tanstack/browser-db-sqlite-persistence
@tanstack/capacitor-db-sqlite-persistence
@tanstack/cloudflare-durable-objects-db-sqlite-persistence
@tanstack/db
@tanstack/db-ivm
@tanstack/db-sqlite-persistence-core
@tanstack/electric-db-collection
@tanstack/electron-db-sqlite-persistence
@tanstack/expo-db-sqlite-persistence
@tanstack/node-db-sqlite-persistence
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/react-native-db-sqlite-persistence
@tanstack/react-router-with-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/tauri-db-sqlite-persistence
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 215 kB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
mainfails CI after #2112. This PR fixes it.trailbase-db-collectionbuild fails:src/trailbase.ts:267and:290,TRecord | undefinedis not assignable toTRecord.query-db-collectionlint fails.Cause
I merged
maininto the #2112 branch before #2112 merged. The pre-commit hook raneslint --fixon the merge commit, but that worktree had no built@tanstack/db. TrailBase and query-db read types fromdb/dist. Without these types, eslint removed non-null assertions, two casts and twoeslint-disablecomments as unnecessary. CI builds the packages first, and there these changes are necessary. I merged #2112 before CI ran on that merge commit.Fix
This PR restores the four files to their versions before #2112:
packages/trailbase-db-collection/src/trailbase.tspackages/query-db-collection/src/query.tspackages/query-db-collection/tests/query.test.tspackages/electric-db-collection/tests/electric-recovery-oracle.test.tsWith
@tanstack/dbbuilt,trailbase-db-collectiontype-checks, and eslint reports no errors in these files.✅ Checklist
pnpm test.🚀 Release Impact
This pull request and its description were written by Isaac.
Summary by CodeRabbit