Conversation
Sola-ris
commented
Sep 20, 2026
| pages = [f for f in archive.namelist() if f != "ComicInfo.xml"] # pyright: ignore[reportUnknownVariableType] | ||
| page_name = pages[int(unwrap(cover.get("Image")))] # pyright: ignore[reportUnknownVariableType] | ||
| ext = Path(page_name).suffix | ||
| ext = Path(page_name).suffix.lower() |
Contributor
Author
There was a problem hiding this comment.
I'm intentionally not checking for the stem here, since comics with a ComicInfo.xml should only contain it and the (numbered) images so if there's a file without an extension the renderer wouldn't work properly anyways
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make archive and ebook thumbnail renderers case-insensitive by converting their extensions to lower-case.
Fixes #1509
Before
After
Files used for testing
samples.zip
Tasks Completed