Repository navigation
feat(sync): carry the Mac's SSH route to iPhone and iPad - #3769
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionSyncField.sshRouteJsonis declared and verified; the Production schema snapshot carries the field the maintainer deployed.~/.ssh/config(hosts, ports, usernames, a hash of the tunnel fields) to the Connection record; both apps read it. iOS never writes it and dials it only while the hash matches the tunnel fields. No keys, key paths or config text are in it.adoptingDeviceLocalState.~/.ssh/configno longer overwrite each other's route on every connect, which dropped the iOS session and moved the hop key.Test plan
SyncFieldParityTestsnow pinssshRouteJsonas written by the Mac only and read by both;ConnectionSyncSchemaTestsandProductionSchemaParityTestspass against the new snapshot.SSHRouteSyncRecordTests(round trip, key set of the synced JSON, clear, fresh record names no route, unreadable route kept, re-spelling kept, foreign route kept, one full fetch),SSHRouteSyncCoordinatorTests(push and merge keep another Mac's route),SyncCoordinatorEchoTests.mergeComparesValuesNotSpelling,SyncRecordMapperSSHRouteTests(pull reads and dials the route, iOS edit keeps it),IOSSyncCoordinatorTests(full fetch once, dirty copy takes the route), import replace and duplicate cases on both apps,PublishedSSHRouteTests.aliasesDoNotMatter.SSHRouteSyncRecordTests.routeStaysOffTheRecordis replaced by the round trip;SyncRecordMapperConnectionTestsmovessshRoutefrom kept-on-this-Mac to written-to-record.verify.sh: package TableProCore (273), macOS sync and SSH suites (179), iOS sync, import and SSH form suites (254), lint, l10n.Follows #3697.