Repository navigation
feat(linux): ship Vietnamese and publish the translation template - #3727
Conversation
J2TeamNNL
left a comment
J2TeamNNL
left a comment
There was a problem hiding this comment.
Code review: 5 findings.
| if [ -n "$linguas" ]; then | ||
| languages="$(sed 's/#.*//' "$linguas")" | ||
| else | ||
| languages="$(find /usr/share/locale -path '*/LC_MESSAGES/tablepro.mo' | cut -d/ -f5)" |
There was a problem hiding this comment.
When no LINGUAS file is passed, the catalogue list is built from the .mo files the package installed, so a package that drops its translations passes. The release-tag path runs this without LINGUAS; a .deb with no tablepro.mo makes find return nothing and the loop never runs. The 'installed no $lang catalogue' check only fires when a LINGUAS file is passed.
| - name: Generate tablepro.pot | ||
| run: | | ||
| meson setup _build --fatal-meson-warnings | ||
| meson compile -C _build tablepro-pot |
There was a problem hiding this comment.
This job pins a different actions/upload-artifact commit (v7.0.1) than build-linux.yml (v7.0.2) for the same work. Align them so bumps don't drift.
|
|
||
| # A linux-vX.Y.Z tag publishes the Linux release: the source and vendor | ||
| # tarballs on GitHub Releases, the signed Debian source package for each | ||
| # tarballs and the translation template on GitHub Releases, the signed Debian source package for each |
There was a problem hiding this comment.
Nit: this header comment line now runs about 105 characters while neighbouring lines wrap near 75.
|
|
||
| #. Translators: your names, one per line, as "Name <email>" or "Name https://site". | ||
| #: crates/app/src/application/about_dialog.rs | ||
| msgid "translator-credits" |
There was a problem hiding this comment.
translator-credits has an empty msgstr, so msgfmt reports 1 untranslated message and the About dialog shows no Vietnamese credit.
| # The build compiles each catalogue without --check. gettext 0.26 and | ||
| # newer also check the {name} placeholders of every rust-format entry. | ||
| msgfmt = find_program('msgfmt', required: false) | ||
| if msgfmt.found() |
There was a problem hiding this comment.
The po tests are only registered when msgfmt is found at configure time, so a build without gettext-tools silently runs zero po tests, contradicting docs/testing.md.
|
Fixes for the review findings, on my fork: J2TeamNNL@48fc512 Fixed:
Skipped: none. Cherry-pick: Checked: sh -n, msgfmt --check on vi.po. Not run: build, shellcheck, actionlint (not installed). |
Summary
po/vi.po: Vietnamese, 1277 of 1278 strings.translator-creditsis left for the reviewer's name. Terms follow the macOS app's Vietnamese where the English matches.po/LINGUASlistsvi. The spec runs%find_lang %{name}and%files -f %{name}.lang.check_packaging.pynow requires both lines, not only%find_lang.poMeson suite:msgfmt --checkon each catalogue inLINGUAS. gettext 0.26 and 1.0 also fail a translation that drops or misspells a{name}placeholder.tablepro.pot, runs theposuite, and uploads thetablepro-potartifact on main.release-linux.yml: a Translation template job. Eachlinux-v*release carriestablepro.pot, covered bySHA256SUMS.po/LINGUASas an argument: each language must be installed, andtablepro --helpunder it must show the catalogue's "Open a new window". A PPA revision of a published release passes noLINGUAS, so it checks the catalogues the package installed.linux-packages.ymlruns on apo/LINGUASchange.path-excludefor/usr/share/localein Ubuntu's dpkg config, and Fedora's%_install_langs en_US.po/<locale>.po:po/README.md(Where translators work) andCONTRIBUTING.md. ROADMAP, testing.md and releasing.md updated.Test plan
release-metadata(packaging suite) fails withviinLINGUASand the old spec, and passes with it.msgfmt --checkonvi.popasses with gettext 0.23.2 (Ubuntu 26.04), 0.26 (Fedora 44) and 1.0 (Ubuntu 26.10). With 0.26 and 1.0 a dropped{schema}or{n}fails.LC_ALL=en_US.UTF-8 LANGUAGE=vi:--helplists--new-window Mở cửa sổ mới,gettext -d tableproreads the same, and the windows above start in Vietnamese. The merged desktop entry and metainfo carry[vi]andxml:lang="vi"and passdesktop-file-validateandappstreamcli validate.verify.shsetup, build, l10n, lint;meson test(all suites); actionlint, zizmor and shellcheck on the changed workflows and scripts.fedora:44. Inubuntu:26.04, a .deb that ships avi.moinstalls it only once the exclude is gone.Not in this PR
po/README.mdlists them as wanted.merge_filedoes not depend on the.pofiles, so an existing build directory keeps an old desktop entry and metainfo after a catalogue changes. A fresh build, as in CI and the packages, merges them.Fixes #3643