Repository navigation
feat(ios): open connections through SSH jump hosts - #3683
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 02:35
datlechin
added a commit
that referenced
this pull request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.TablePro.jumphostkeys.<id>), synced like the tunnel key and never exported. Duplicate, delete and the sync purge reach them through the connection id. Import Replace keeps a hop's key when host, port and username match.authMethod,privateKeyPath) round-trip untouched. Save merges with hops another device changed while the form was open.enabledwas never written).Int32(port), the database port included. It is now refused before dialing.SSHJumpRelayFencemoves toTableProSSHTransport, the hop relay start toLibSSH2JumpRelay.swift, both compiled by the Mac and iOS apps. Only Mac change:SSHChannelRelaysends withMSG_NOSIGNAL, so a local peer that closed first ends the relay instead of killing the process with SIGPIPE.Test plan
SSHTunnelFactoryTests(two hops dial, verify and sign in in order; refusals before dialing; Same Key; agent server; out-of-range port),SSHJumpChainTeardownTests,JumpHostCredentialTests,ConnectionFormViewModelJumpHostTests,ConnectionFormEditsTests(hop edits keep Mac fields, merge with another device,enabledwritten),ConnectionFormViewModelSSHKeyTests,ConnectionErrorClassifierTests,SSHChannelRelayTests(on main the process dies on SIGPIPE),SSHConfigurationTests.jumpHostsAreRefusedreplaced (hops now dial);unsupportedAuthMethodDiscardsuses Keyboard Interactive (agent is now supported);prefixesMatchStoredAccountslists the new prefix;iosCreatedConfigOmitsMacKeysretitled;proxyJumpCleanupDrainsRelayBeforeFreeandproxyJumpCompletionDisarmsLateStopmove fromSSHTunnelErrorTeststoSSHJumpRelayFenceTests.Fixes #3635
Not in this PR
LibSSH2Tunnel.swift:234-245). Harmless once the send is flagged; order left as is.sshEnabledthe sync mapper writes can go stale.~/.ssh/configand SSH profiles never reaches iOS.ConnectionImportAnalyzer.swift:162-164).