Repository navigation
feat(ios): open the referenced row from a foreign key preview - #3682
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REFERENCES parentpoints at the parent's primary key, and the pairs of a composite key share one name.[col]closes with], MySQL doubles backslashes, and a number-like value against a text column is quoted ('02134') from the column's type.Test plan
FilterSQLGeneratorTests(TableProCore),SQLBuilderFilterLiteralTests,SQLBuilderSingleRowLookupTests,SQLiteDriverFileTests,MySQLForeignKeyCatalogTests,MySQLColumnListingTests,MySQLDriverLegacyServerTests,DataBrowserViewModelTests,RowDetailViewModelTests,ForeignKeyReferenceTests,ForeignKeyPreviewModelTests,TableBrowserIdentityTests.DataBrowserViewModelTestsprimaryKeyExtractionis rewritten forprimaryKeyValues(forRowAt:), which replaces the old single-value API.CustomerId = 2(Filter badge 1) with the row on screen, "1 of 1", Edit available. Back returns to the filtered list, then to Invoice. SupportRepId in the sheet links to Employee.Fixes #3636
Not in this PR
bit(n)filter columns still compare bare (= 101), which has no operator. Main does the same for user filters, and MySQL BIT needs the bare form. Open Table on such a key shows the browser's load error.SQLiteForeignKeyGrouping.resolvedNameskeeps a declared name equal to another key's positionalfk_<table>_<id>, so the schema editor groups two keys as one composite key. iOS no longer passes the DDL.TableProQuery/SQLStatementGenerator.swiftandTableQueryBuilder.swiftrepeat the old[quoting and number guessing, but nothing calls them.