Repository navigation
feat(ios): run the statement at the cursor in the query editor - #3681
Merged
Merged
Conversation
Redis text now splits into commands at ; and line breaks for Run, Run All and Safe Mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;, never comment-only text.Cmd+Returnruns at the cursor,Cmd+Shift+Returnruns all,Cmd+.stops. A key-command run keeps the keyboard up.GObatch.;or a line break outside quotes. On main,GET aandGET bon two lines ran asGET a GET b, and Safe Mode read only the first verb.QueryScriptTests.redisIsOneCommandpinned the old Redis behavior and is replaced byredisSplitsIntoCommands.Test plan
QueryRunTargetTests,RedisCommandSplitterTests,SQLEditorHandleTests,QueryScriptTests.redisSplitsIntoCommandsandredisTrimKeepsAnEscapedBlank,SQLWriteClassifierTests.redisWriteInALaterCommand,RedisCommandParsingTests.unclosedQuoteGivesNil,escapedLineBreakMatchesSplitterandescapedTrailingBlankReachesTheDriver.QueryEditorViewModelTestsstill pass.SELECT 1 AS a;/SELECT 2 AS b;/SELECT 3 AS c;, cursor on line 2: main runs all three and showsc = 3, this branch runs line 2 and showsb = 2.SELECTselected shows Run Selection and runs the selection. Cursor after the last statement: the result stays and the note shows.Not in this PR
;as one command, the same defect fixed here for iOS (databases/redis.mdxexample).RedisArgumentCodecescapes: a lone trailing backslash (DEL victim\) is dropped on iOS and kept on the Mac..onDisappeardrops the pending query save.Fixes #3632