Repository navigation
feat(ios): mark synced connections that open only on a Mac - #3680
Merged
Merged
Conversation
datlechin
enabled auto-merge (squash)
October 20, 2026 02:04
datlechin
added a commit
that referenced
this pull request
Oct 20, 2026
datlechin
added a commit
that referenced
this pull request
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DriverFactory.refusal(for:), from the iOS driver list plus the Mac socket check.ConnectionManager.connectchecks it first, before the keychain read and the SSH tunnel. That covers list taps, restore, links, Spotlight, Handoff, Shortcuts, reconnect and Test Connection.requireordisableand left out unset paths. The Mac cannot decode that and skipped the record. iOS now writes the Mac's mode names and every path key, and writes a Mac Preferred back as Preferred (iCloud, local storage,.tableproexport).ConnectionErrormessages are localized. A port of 0 no longer shows in the detail line.ConnectionErrorClassifierTestspinned "Driver Unavailable"; it now expects "Opens on Mac Only".Test plan
ConnectionManagerTests(a MongoDB connect with SSH on throws before any tunnel),SSLConfigurationWireTests,SyncRecordMapperSSLTests.IOSDriverFactoryRefusalTests,MacOnlyImportRowTests,ConnectionListRowModelTests,ScenePresenterTests(refusal held behind an open connection),ConnectionDetailFormatterTests,ConnectionErrorClassifierTests,IOSConnectionImportServiceTests.preferredSSLModeSurvivesImport, andMacOnlyConnectionFormTestsas a guard..tableprofile opened in the app.Not in this PR
Fixes #3631