Repository navigation
Restore spaces between words and numbers in scored interfaces - #92
Open
kratos0718 wants to merge 1 commit into
Open
kratos0718 wants to merge 1 commit into
kratos0718 wants to merge 1 commit into
Conversation
Five tasks' agent-visible contracts had lost the space before a number
("returns422", "Adult1599", "quantity0..99"), which agents read
literally. The spaces are restored in amc-theatres, angi, everydollar,
fandango and freshdirect, and check_tasks.py now reports a word fused to
the number after it, so the release checks catch it again.
Closes TIGER-AI-Lab#23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
The agent-visible
environment/seed/scored-interfaces.jsonof five tasks had lost the space between a word and the number after it. This restores it in all 106 places:Adult 1599/Child 1199/Senior 1399,Standard 0/IMAX 499/Dolby Cinema 399,returns 422,an unexpected 500low_cents 9375/high_cents 135000,outside 0..100000,Anonymous 401,HTTP 200integer quantity 0..99,ticket_count 0,at least 5 characters,the next 14Brooklyn 11201,Manhattan 10001,HTTP 404,at least 10succeeds 200,exact HTTP 200,reject 404The counts differ slightly from the issue because some matches overlap (
Adult1599/Child1199). I read every match in context before changing it: each one is a status code, price, ZIP code, length or range that belongs after a space. The JSON still parses, and the strings don't appear anywhere else in the repository, so nothing else had to change with them.For the release checks,
scripts/check_tasks.pynow reports a word followed directly by a number anywhere in a task'sscored-interfaces.json(keys and values). Names that end in a number, such asseed_sha256,utf8orbase64, are allowed, which keeps the*_sha256fields in hipcamp, linkedin, notion and ubereats passing.docs/development.mdmentions the new check.Validation:
mainfiles, the check flags exactly amc-theatres, angi, everydollar, fandango and freshdirect; after the fix,uv run python scripts/check_tasks.py --code-onlypasses for all 71 tasks.tests/test_check_tasks.pycover a fused number being reported and spaced numbers or numbered names being accepted; the first fails without the check.uv run python -m unittest discover -s tests: 56 tests OK.ruff checkandruff format --checkpass.