Repository navigation
Conversation
fetch_hf drives the hf download command line (--repo-type, --local-dir, --revision, --include), and the hf CLI is where huggingface-hub 1.0 made its breaking changes. With >=1.0 open-ended, pip install websitebench after a 2.0 release would pick up a CLI the download path was never run against. Declare >=1.0,<2, and test that the locked hf download accepts every flag fetch_hf passes, so a future bump that drops one fails in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11
Harbor is pinned exactly, but
huggingface-hubwas open-ended (>=1.0).fetch_hfdrives thehf downloadcommand line with--repo-type,--local-dir,--revisionand--include, and thehfCLI is where huggingface-hub 1.0 made its breaking changes.Changes
pyproject.toml:huggingface-hub>=1.0,<2, with the reason in the comment above it.uv.lock: only therequires-distspecifier changes; the resolved version stays 1.33.0.test_hf_download_accepts_every_flag_fetch_hf_passesrecords the commandfetch_hfbuilds and checks each flag against the lockedhf download --help, so a future bump that drops one fails in CI.Checks
uv lock --checkuv run python -m unittest discover -s testsuv run ruff check scripts src testsuv run ruff format --check scripts src tests