Skip to content

Bound huggingface-hub below 2 - #91

Open
reacher-z wants to merge 1 commit into
mainfrom
packaging/bound-huggingface-hub
Open

reacher-z wants to merge 1 commit into
mainfrom
packaging/bound-huggingface-hub

Conversation

@reacher-z

Copy link
Copy Markdown
Collaborator

Closes #11

Harbor is pinned exactly, but huggingface-hub was open-ended (>=1.0). fetch_hf drives the hf download command line with --repo-type, --local-dir, --revision and --include, and the hf CLI is where huggingface-hub 1.0 made its breaking changes.

Changes

  • pyproject.toml: huggingface-hub>=1.0,<2, with the reason in the comment above it.
  • uv.lock: only the requires-dist specifier changes; the resolved version stays 1.33.0.
  • test_hf_download_accepts_every_flag_fetch_hf_passes records the command fetch_hf builds and checks each flag against the locked hf download --help, so a future bump that drops one fails in CI.

Checks

  • uv lock --check
  • uv run python -m unittest discover -s tests
  • uv run ruff check scripts src tests
  • uv run ruff format --check scripts src tests

fetch_hf drives the hf download command line (--repo-type, --local-dir,
--revision, --include), and the hf CLI is where huggingface-hub 1.0 made
its breaking changes. With >=1.0 open-ended, pip install websitebench
after a 2.0 release would pick up a CLI the download path was never run
against. Declare >=1.0,<2, and test that the locked hf download accepts
every flag fetch_hf passes, so a future bump that drops one fails in CI.
@reacher-z reacher-z added reproducibility Pinned dependencies and deterministic results packaging PyPI package and release index labels Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packaging PyPI package and release index reproducibility Pinned dependencies and deterministic results

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bound huggingface-hub below the next major version

1 participant