Repository navigation
Conversation
restore_modes makes executable only the files the index lists, because Hugging Face does not keep file modes. Nothing checked that the list agrees with the checkout, so a script made executable in tasks/ but left out of the index would install from Hugging Face without its executable bit. The index and the source modes agree for all 70 tasks today; the test keeps it that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restore_modessets the executable bit only on the files the release index lists, because Hugging Face does not keep file modes. Nothing checked that list against the checkout, so a script made executable intasks/but missing from the index would install from Hugging Face without its executable bit.The new test walks every file in
tasks/<task>and checks that it is executable exactly when the task'sexecutablesinwebsitebench-v1.jsonlists it. All 70 tasks agree. Clearing the bit ontasks/medium/environment/reference/run.sh, or setting it ontasks/medium/instruction.md, makes the test fail.uv run python -m unittest discover -s testsuv run ruff check scripts src testsuv run ruff format --check scripts src tests