Repository navigation
Conversation
Every task ships its own copy of the verifier package. The 26 modules that all 70 tasks carry are byte-identical today, which is what makes a reward on one task comparable with a reward on another. A fix applied to some copies and not the others would break that silently. When more than one task is checked, report each shared module whose copies differ and name the tasks that hold the minority copy. Task-specific modules, such as t3_checks.py in three tasks, are left alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every task ships its own copy of the verifier package. The 26 modules under
tests/websitebench/that all 70 tasks carry are byte-identical, which keeps rewards comparable across tasks. A fix applied to some copies and not the others would go unnoticed.Changes
scripts/check_tasks.pygainsshared_verifier_drift(tasks): it hashes each file undertests/websitebench/that every checked task has and reports a differing copy asFAIL shared verifier: <path> differs from the copy in N tasks in: <tasks>.t3_checks.pyin three tasks) are left alone.docs/development.mdmentions the check.Tests
New
SharedVerifierDrifttests. Editing one copy of a shared module innotionmakes the check fail and namenotion; the unmodified tree passes.uv run python -m unittest discover -s testsuv run ruff check scripts src testsuv run ruff format --check scripts src testsuv run python scripts/check_tasks.py --code-only