Skip to content

SideloadedSubtitle: add tests for the connector - #141

Draft
ceyhun-o wants to merge 2 commits into
mainfrom
maintenance/sideloaded-subtitle-tests
Draft

ceyhun-o wants to merge 2 commits into
mainfrom
maintenance/sideloaded-subtitle-tests

Conversation

@ceyhun-o

@ceyhun-o ceyhun-o commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds 15 tests to THEOplayerConnectorSideloadedSubtitleTests. Test code only; no production code changes.

Covered

  • SourceTimestampTests, TimestampStringUtilsTests: timestamp parsing/formatting.
  • SubtitlesTransformerTests: SRT conversion and composeTranformationUrl cache-busting.
  • SubtitlePlaylistTests: subtitle group/rendition injection into master playlists (default, language, URI).
  • SubtitlePlaybackTests: playback smoke test (English track added, first cue ENTER).

Expected failures (suspected production bugs, not fixed here)

  • composeTranformationUrl uses millisecond precision for t=, so consecutive calls within 1 ms return the same URL. Still reproduces: 2 unique values out of 100 calls. Kept as XCTExpectFailure.
  • Injected subtitle renditions are still double-encoded: MasterPlaylistParser.appendSubtitlesLines emits french%2520track.vtt for a french%20track.vtt source. SideloadedSubtitle: Resolve playlist URIs without decoding existing percent-escapes #134 fixed only existing playlist URIs. The XCTExpectFailure matches only the %2520 form.

Local results

  • Xcode 26.6 (17F113), iPhone 17 on iOS 26.5, and Xcode 27.0 RC (27A266a) on iOS 27.0: 51 tests, 48 passed, 2 expected failures, 1 failed.
  • The failure is the playback smoke test, which timed out waiting for the first cue ENTER. Both simulators logged CoreAudio errors, so this looks like the VM environment, but that is not confirmed. GitHub CI is the reference run.

Link to Devin session: https://dolby.devinenterprise.com/sessions/d3ea677091c5459e935f6355a5585d17
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/d3ea677091c5459e935f6355a5585d17?variant=devin
Requested by: @ceyhun-o

ceyhun-o and others added 2 commits November 20, 2026 03:01
…avior

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant