Repository navigation
Conversation
…avior Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 15 tests to
THEOplayerConnectorSideloadedSubtitleTests. Test code only; no production code changes.Covered
SourceTimestampTests,TimestampStringUtilsTests: timestamp parsing/formatting.SubtitlesTransformerTests: SRT conversion andcomposeTranformationUrlcache-busting.SubtitlePlaylistTests: subtitle group/rendition injection into master playlists (default, language, URI).SubtitlePlaybackTests: playback smoke test (English track added, first cueENTER).Expected failures (suspected production bugs, not fixed here)
composeTranformationUrluses millisecond precision fort=, so consecutive calls within 1 ms return the same URL. Still reproduces: 2 unique values out of 100 calls. Kept asXCTExpectFailure.MasterPlaylistParser.appendSubtitlesLinesemitsfrench%2520track.vttfor afrench%20track.vttsource. SideloadedSubtitle: Resolve playlist URIs without decoding existing percent-escapes #134 fixed only existing playlist URIs. TheXCTExpectFailurematches only the%2520form.Local results
ENTER. Both simulators logged CoreAudio errors, so this looks like the VM environment, but that is not confirmed. GitHub CI is the reference run.Link to Devin session: https://dolby.devinenterprise.com/sessions/d3ea677091c5459e935f6355a5585d17
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/d3ea677091c5459e935f6355a5585d17?variant=devin
Requested by: @ceyhun-o