Repository navigation
Lens: link THEOplayer's CMCD data to the Lens session (Lens SDK 0.7.0) - #136
GillesMoris-Dolby merged 4 commits into
Conversation
The connector keeps player.cmcd.linkedSessionId equal to its handle's Lens session ID through the session delegate Lens 0.7.0 adds: set after join, updated on every session change, cleared on destroy. Lens 0.7.0 ships LensSDK as a prebuilt dynamic framework, which the connector links and the app embeds once, and decides the session when a source is set. THEOplayer gains cmcd.linkedSessionId in 11.16.0 (theoplayer-next PR 8186), hence the new minimum. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ire it in the example Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Status for follow-up
CircleCI on the THEOplayer dependency (theoplayer-next pipeline 19326,
I re-ran both failed workflows from their failed jobs (web |
|
CircleCI re-runs on the THEOplayer dependency (theoplayer-next
Android was a flake. On web, |
…sionId THEOplayer.cmcd and the CMCD protocol moved behind @_spi(Core) in theoplayer-next PR 8186. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Updated for |
72d561b
into
feature/lens-connector
Summary
Stacked on #133. Links THEOplayer's own CMCD data to the Lens session, and moves the Lens connector to Lens SDK 0.7.0.
LensConnectorkeepsplayer.cmcd.linkedSessionId(THEOplayer API behind@_spi(Core), imported with@_spi(Core) import THEOplayerSDKinLensConnector.swiftand the tests) equal to its handle's Lens session ID, through the session delegate Lens 0.7.0 adds (addSessionDelegate): set right after join (also when joining a session another SDK already decided on the player), updated on every session change, cleared ondestroy(). THEOplayer sends it ascom.dolby.optiview-lsid(data spec keylsid, optiview-lens-data-spec#36).0.7.0..<0.8.0:LensSDKis now a prebuilt dynamic framework. The connector links it without embedding it; the app embeds it once (checked in the example app: oneLensSDK.frameworkinFrameworks/). With an observed adapter, Lens decides the session when a source is set, so the session test now expects thesidat source set and the same one at play.Blocked on THEOplayer
THEOplayer.cmcd/CMCD.linkedSessionIdcomes from theoplayer-next PR 8186 (feature/cmcd-lens-session-link), which is not released.Package.swiftrequires THEOplayerSDK 11.16.0 as the first version with it (assumed: the next minor after 11.15.1; adjust once the release is known). This raises the minimum for every connector in the package, as they share the dependency.Until that version is published, CI here cannot resolve the package:
build-and-testfails at dependency resolution. That is expected; keep this PR in draft until THEOplayer 11.16.0 is out, then re-run CI.Tests done (locally)
Built
THEOplayerSDK.frameworkfromfeature/cmcd-lens-session-link(f7f6b4d2a17, with the@_spi(Core)change) for the iOS simulator and pointed the package at it locally (not committed):THEOplayerConnectorLensTests: 29/29 pass (iPhone 17, iOS 26.5), against Lens 0.7.0. New: the linked session ID follows the Lens session across a source change and is cleared on destroy, and is set when joining a session already in progress. Both fail when the connector stops syncing (checked by disabling it).@_spi(Core)the connector no longer compiles ('cmcd' is inaccessible due to '@_spi' protection level), so the SPI is in effect.LensSDK.frameworkonce.