Repository navigation
Fix the DRM example, add a feature modules example, and stop pinning package versions in other examples - #988
Merged
Conversation
… stream Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
ceyhun-o
marked this pull request as ready for review
November 20, 2026 13:19
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
…mple Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
albertonantiattheo
approved these changes
Nov 20, 2026
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Comment on lines
+32
to
+33
| Open Video UI imports the player from "theoplayer/chromeless", so that name points to "theoplayer/core" as well: | ||
| the player then only has the features that are imported below. |
Collaborator
There was a problem hiding this comment.
We'll want to fix this in Open Video UI too, but that will probably need a major bump. For now, this'll work just fine. 👍
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
Co-Authored-By: Ceyhun Ozgoc <ceyhun.ozgoc@dolby.com>
MattiasBuelens
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes two Web SDK examples.
DRM example: replace the expired stream
The KeyOS stream in the DRM example has expired. The DRM source is now a single Axinom HLS (CMAF,
cbcs) test vector withintegration: 'axinom', a testtoken, and license URLs for Widevine, PlayReady and FairPlay.DrmDemo.tsx: the source label and the "Selected stream" readout match the new stream.01-drm.mdx: the description now says one HLS stream with three key systems, and links to the Axinom integration guide instead of KeyOS.New example: feature modules (11.16.0)
New page
examples/getting-started/02-feature-modules.mdx, next to "Basic player".feature-modules/demo.htmlimports onlytheoplayer/coreandtheoplayer/hls, plus Open Video UI, and plays Big Buck Bunny (HLS) in<theoplayer-default-ui>.@2, like the other examples; Lit stays pinned on jspm because Open Video UI imports it by bare name.theoplayer/chromelessmaps tomodule/core.js, because Open Video UI imports the player from it.FeatureModulesDemo.tsxshows the imported modules,THEOplayer.featuresandTHEOplayer.versionin a box under the player.Debug display example: load Open Video UI
@2from unpkg@2, like the other examples, instead of a pinned 2.6.1 from jspm. Lit is updated to 3.3.2.Conviva and Yospace examples
@3from unpkg instead of a pinned 3.3.2 / 3.0.0.Testing
npm run lint,npm run typecheckandnpm run check-formatpass.THEOplayer.featuresis["hls"]and playback advances.