fix(func): SUPERTREND's outputs are supertrend and trend - #764
Merged
Merged
Conversation
TA-Lib C 0.8.1 released SUPERTREND with outputs outSupertrend and outTrend.
_func.pxi was generated against a pre-release C that still called them
outReal and outInteger, so help(talib.SUPERTREND) and the abstract stub
listed "real" and "integer", while abstract.Function('SUPERTREND').output_names
already reported the released names at runtime.
_ta_lib.pxd now declares the header's parameter names, and _func.pxi,
abstract.pyi and _ta_lib.c are regenerated against the released 0.8.1
header. Return values, dtypes and argument order do not change.
Claude-Session: https://claude.ai/code/session_01TuVjx2Q5urdmwi5opzfCp8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TA-Lib C 0.8.1 released
SUPERTRENDwith outputsoutSupertrendandoutTrend._func.pxiwas generated against a pre-release C that still called themoutRealandoutInteger, so v0.8.0 shows the old names in two places:Change
_func.pxi: regenerated withtools/generate_func.pyagainst the released 0.8.1 header. This changes onlySUPERTREND, in its docstring and local variable names.abstract.pyi: regenerated withtools/generate_abstract_stub.py. It reads the compiled docstring, so it follows_func.pxi._ta_lib.pxd: the only hand edit. TheTA_SUPERTRENDdeclaration now uses the header's parameter names._ta_lib.c: regenerated with Cython 3.3.0 and numpy 2.2.0, the pair that reproduces v0.8.0's_ta_lib.cbyte for byte. The diff is the renamed identifiers and the compressed docstring tables.CHANGELOG: one[FIX]line under 0.8.1.Return values, dtypes and argument order are unchanged.
Checks
Built against TA-Lib C v0.8.1 compiled from the
v0.8.1tag:pytest tests/: 1696 passed.help(talib.SUPERTREND)listssupertrendandtrend;talib.SUPERTREND(h, l, c)still returns(float64, int32)._stream.pxiandstream.pyiproduces no diff._ta_lib.pxdand the 0.8.1ta_func.hwere compared by parameter name.TA_SUPERTRENDwas the only real mismatch; the others differ only in()vs(void)spelling.https://claude.ai/code/session_01TuVjx2Q5urdmwi5opzfCp8