Repository navigation
fix(deploy): wait for the backend to be ready in deploy::up - #321
Merged
Merged
Conversation
deploy::up returned as soon as keycloak was running, while the backend was still compiling and creating its tables. CI's Seed step runs db::seed right after it, and the seed creates the same tables, so the two occasionally raced and Postgres rejected one of them (`duplicate key value violates unique constraint "pg_type_typname_nsp_index"`). The backend only listens once its schema and migrations are done, so waiting for its readiness probe means the tables exist before anything else touches the database. quitsh caps the wait at 100s; if CI's cold compile turns out to exceed that, a separate wait step with its own timeout is the follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a random race condition that occured in the ci::
deploy::upreturned as soon as keycloak was running, while the backend was still compiling and creating its tables. - CI's Seed step runsdb::seedright after it, and the seed creates the same tables, so the two occasionally raced and Postgres rejected one of them (duplicate key value violates unique constraint "pg_type_typname_nsp_index").