Skip to content

Forward registered images across the renderer channel #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SunkenInTime merged 7 commits into from
Jul 31, 2026
Merged

Forward registered images across the renderer channel #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6361912
Forward registered images across the renderer channel
Jul 31, 2026
6176383
Replay registered images to a replacement host; install retained imag…
Jul 31, 2026
1432fd7
Shape-check image uploads and tear down half-replayed sessions
Jul 31, 2026
4d5ab04
Drop host-refused images from the reconnect replay
Jul 31, 2026
97b85a6
Forward registered fonts across the renderer channel
Jul 31, 2026
9097a81
Point the resource contains-check at the generalized names
Jul 31, 2026
8ca5b4b
Reject unknown resource kinds before the removal branch
Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,9 +599,38 @@ pub fn build(b: *std.Build) void {
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "FRAME BUDGET EXCEEDED pid=%d took=%llums budget=%llums" },
// Every frame is measured (trace-gated per-frame line for future
// receipts), on both the export and static/refusal paths.
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "client.frameRenderBeginNs = NativeSdkTimestampNanoseconds();" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "client.frameRenderBeginNs = NativeSdkRenderHostMonotonicNanoseconds();" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "weaver-render-host: frame-trace pid=%d" },
});
addFileContainsCheckStep(b, file_contains_checker, test_step, "test-macos-shared-renderer-images", "Verify registered images cross the renderer channel ahead of their packets", &.{
// The protocol message and its validator (pixels_len == 0 is a
// removal; the ceiling mirrors canvas_limits).
.{ .path = "src/platform/macos/renderer_protocol_mach.h", .pattern = "kWeaverRendererMachMsgResourceUpload" },
.{ .path = "src/platform/macos/renderer_protocol_mach.h", .pattern = "weaverRendererMachResourceUploadValid" },
.{ .path = "src/platform/macos/renderer_protocol_mach.h", .pattern = "kWeaverRendererMachMaxImageBytes = 1024 * 1024" },
// One storage implementation for both worlds: the app host's
// stores in-process, the per-client headless stores in the host.
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "static BOOL NativeSdkCanvasStoreImage(" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "- (NSMutableDictionary<NSString *, NSImage *> *)activeCanvasImageStore" },
// The device-less client forwards uploads (and removals) instead
// of storing locally; the host stores into the client's renderer.
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "uploadImageWithId:image_id width:width height:height rgba8:rgba8 byteLength:rgba8_len" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "NativeSdkRenderHostHandleResourceUpload(strongClient, &message.resource.upload);" },
// An image arriving before the first frame constructs the
// renderer; the export completion binds lazily so that order works.
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "if (!client.renderer.headlessExportCompletion) {" },
// A replacement host gets every registered image replayed on
// reconnect, and a retain action installs from the store when the
// fresh view cache lacks the entry — art survives host crashes.
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "registeredImagesById" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "if (cacheKey && !imageCache[cacheKey] && imageStore[cacheKey]) {" },
// Fonts ride the same resource channel into a PER-CLIENT table,
// swapped in around each present so widgets' font ids can never
// collide in the shared host; faces replay after reconnect.
.{ .path = "src/platform/macos/renderer_protocol_mach.h", .pattern = "kWeaverRendererMachResourceFont" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "NativeSdkRenderHostSetActiveFontTable" },
.{ .path = "src/platform/macos/appkit_host.m", .pattern = "registeredFontsById" },
});
addFileContainsCheckStep(b, file_contains_checker, test_step, "test-macos-shared-renderer-client", "Verify the device-less widget client keeps the shared-renderer contract", &.{
// No Metal object is ever created in client mode; availability is
// device-less by design.
Expand Down
Loading