Fix the shared-renderer client contains-check pattern - #25
Conversation
The slice-3 review hardening reworded the disconnect log to 'host gone
or wedged, will reconnect' after the check step pinned the original
phrasing; pin the invariant ('will reconnect' — the reconnect promise)
rather than the exact prose.
Greptile SummaryThis change corrects the macOS shared-renderer contract check so it matches the exact reconnect message emitted after a timed frame-send failure. The executed source check confirmed that the previous phrase is absent from T-Rex validation blockedThe repository's native check could not be run because the Confidence Score: 5/5Safe to merge: the assertion now tracks the exact reconnect message emitted by the intended macOS frame-send failure path. The final defect set is empty. Executed validation confirmed that the replacement text is present in the intended branch and that the obsolete text would not match the current implementation. Files Needing Attention: No files need further attention.
What T-Rex did
Reviews (2): Last reviewed commit: "Pin the exact reconnect log line, not a ..." | Re-trigger Greptile |
Review is right that a bare 'will reconnect' substring could be satisfied by unrelated prose; pin the frame-send failure branch's exact current line instead.
|
@greptileai review |
The slice-3 review hardening reworded the disconnect log to 'host gone or wedged, will reconnect' after test-macos-shared-renderer-client pinned the original phrasing, so the check fails on weaver-main (caught by weaver CI in SunkenInTime/weaver#47). Pin the invariant — the reconnect promise — not the exact prose. Verified: the check step passes locally.