Hide view cone elevation controls

[SunkenInTime]

What changed

• remove the user-facing view elevation and vision calibration controls from attached and standalone view cones
• keep adjacent-page actions available where applicable
• normalize the agent quick-action row so ability buttons remain evenly spaced across wider context-menu rows
• add widget coverage for the hidden controls and menu sizing

Why

The elevation and calibration controls are internal implementation details and should not appear in the user-facing tactical workflow. Removing them keeps the context menu focused while preserving the existing view-cone behavior.

User impact

View-cone context menus are smaller and clearer. Agent ability shortcuts remain consistently sized and centered.

Validation

• dart format --output=none --set-exit-if-changed on the four changed Dart files
• flutter test test/lineup_add_item_interaction_test.dart test/view_cone_agent_drag_feedback_test.dart

Summary by CodeRabbit

• New Features

  • Simplified view-cone context menus to focus on adjacent-page copy actions.
  • Added context-menu actions for navigating adjacent pages when available.
  • Improved agent quick-action layouts with consistent sizing, spacing, and alignment.

• Bug Fixes

  • Removed elevation and calibration controls from view-cone menus.
  • Ensured quick-action buttons consistently render at the intended size and width.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 11487602-efa2-468e-9e3e-b253bd7a1dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 4cdcbcf and d3ae033.

📒 Files selected for processing (4)

• lib/widgets/draggable_widgets/agents/agent_widget.dart
• lib/widgets/draggable_widgets/utilities/view_cone_widget.dart
• test/lineup_add_item_interaction_test.dart
• test/view_cone_agent_drag_feedback_test.dart

---

📝 Walkthrough

Walkthrough

Agent quick-action menus now use shared sizing and spacing constants. View-cone menus remove elevation and calibration controls. Tests verify menu contents, dimensions, alignment, and spacing.

Changes

Context menu updates

Layer / File(s)	Summary
Agent quick-action menu layout lib/widgets/draggable_widgets/agents/agent_widget.dart, test/lineup_add_item_interaction_test.dart	Agent menus cache adjacent-page actions, remove view-cone controls, and use constrained, centered quick-action rows with shared 36×36 sizing and 4-pixel spacing.
View-cone context menu behavior lib/widgets/draggable_widgets/utilities/view_cone_widget.dart, test/view_cone_agent_drag_feedback_test.dart	View-cone menus conditionally show adjacent-page actions. Tests verify attached and free view-cone menu behavior and confirm that elevation and calibration options are absent.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to d3ae0

The change hides internal view-cone controls and keeps agent actions evenly spaced without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Possibly related PRs

• SunkenInTime/icarus#113: Both changes modify AgentWidget context-menu and provider behavior.
• SunkenInTime/icarus#115: Both changes modify ViewConeWidget context-menu behavior.
• SunkenInTime/icarus#119: Both changes modify view-cone menus and geometry-related UI behavior.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the primary change: hiding view-cone elevation controls.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch agent/hide-view-cone-elevation-controls

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This change removes elevation and calibration controls from attached and standalone view-cone menus, centers agent ability quick actions, and avoids exposing an empty menu when a standalone view cone has no available adjacent-page action.

Focused widget coverage verified that attached view-cone agents retain usable quick actions without elevation or calibration controls, standalone cones with no adjacent-page action expose no context-menu region, and eligible adjacent-page utility copying continues to work. No defects were found.

Confidence Score: 5/5

The menu changes are safe to merge based on focused runtime coverage of the affected attached and standalone view-cone interactions.

The focused widget test and existing view-cone and page-copy tests completed successfully, exercising the removed controls, quick-action layout, empty-menu behavior, and adjacent-page copy behavior without demonstrating a regression.

Files Needing Attention: No files need follow-up attention.

T-Rex Logs

What T-Rex did

• The focused PR125 view-cone UI validation test completed with exit code 0, validating the focused attached-agent and standalone no-action widget checks.
• The broader coverage test command for view-cone drag feedback and strategy-page semantics completed with exit code 0, validating the view-cone menu and adjacent-page utility-copy coverage.
• The validation run confirms that removed controls are absent, empty standalone menus are not installed, and eligible adjacent-page copying remains available.

_{Ran code and verified through T-Rex}

_{Reviews (1): Last reviewed commit: "Hide view cone elevation controls" | Re-trigger Greptile}