Skip to content

Bring the live-flow end-to-end specs up to date - #289

Merged
nonprofittechy merged 2 commits into
mainfrom
fix/optional-services-e2e
Oct 8, 2026
Merged

nonprofittechy merged 2 commits into
mainfrom
fix/optional-services-e2e

Conversation

@nonprofittechy

Copy link
Copy Markdown
Member

The live-flow Playwright specs (test-optional-services-e2e, reorganized-filing-matrix, document-classification-sentinel) had drifted from the app and failed before reaching their checks. CI does not run them, which is how they drifted.

  • Upload → Preview → Confirm case: the specs expected Upload to go straight to Confirm case, and Confirm case sends a filer back while the first file is still being read. The shared continueFromUpload waits for the analysis and confirms the prepared PDFs on Preview.
  • Your information: State is a <select>. The fill helper (fillRequiredInputs, now shared) selects an option for a select field.
  • Fees: the page asks how the filer will pay before it lists accounts. choosePayByAccount waits for the accounts to load, then chooses to pay by account.
  • Review: the total and breakdown are #fee-quote-amount and #fee-quote-breakdown.
  • Fee waiver: a waiver copy added on Fees must be confirmed ("This copy looks right") before Review is offered.
  • Sentinel: Lake County's live code list now names that filing type "Petition", not "Petition Dissolution of Marriage/Civil Union". The classifier was right.

Validation

Against a local server on main with the Tyler test account:

  • test-optional-services-e2e: passes. Real quotes of $262.25 with the optional service and $256.25 after removing it on Review.
  • document-classification-sentinel: passes.
  • reorganized-filing-matrix, Adams adoption scenario only, with E2E_PAYMENT_MODE=waiver: filed, envelope 324890.

🤖 Generated with Claude Code

nonprofittechy and others added 2 commits October 8, 2026 09:15
The optional-services, filing-matrix and classification specs had
drifted from the app and failed before reaching their checks:

- Upload now passes through Preview, and Confirm case sends a filer
  back while the first file is still being read. continueFromUpload
  waits for the analysis and confirms the prepared PDFs.
- State on Your information is a select. fillRequiredInputs (now
  shared) selects an option for a select field.
- Fees asks how the filer will pay before it lists accounts, and only
  wires up that choice once the accounts have loaded.
  choosePayByAccount waits for them, then chooses to pay by account.
- Review's total and breakdown are #fee-quote-amount and
  #fee-quote-breakdown.
- A fee waiver copy added on Fees must be confirmed ("This copy looks
  right") before Review is offered.
- Lake County now names the sentinel's filing type "Petition" in its
  live code list.

Checked against a local server on main with the Tyler test account:
the optional-services and classification specs pass, and the Adams
adoption scenario filed with a fee waiver (envelope 324890).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Tyler test account's old e-check account was declined at submission
(Tyler code 121) and has been replaced; the spec now relies only on the
account type.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nonprofittechy
nonprofittechy requested a balanced review from Copilot October 8, 2026 15:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@nonprofittechy
nonprofittechy merged commit 23c449f into main Oct 8, 2026
8 checks passed
@nonprofittechy
nonprofittechy deleted the fix/optional-services-e2e branch October 8, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants