Repository navigation
Wait for upload and analysis before enabling preview navigation - #285
Merged
Merged
Conversation
Continue stayed disabled until the status poll reported the analysis ready, and extraction review sent filers back while it was pending. If the extraction worker was down or backed up, or the poll kept failing, the filer could not move forward at all. After EXTRACTION_WAIT_LIMIT the filer may continue and enter the case details by hand. The server enforces the limit in extraction review and reports the remaining wait to the page, which opens Continue on a timer so a failing status poll cannot hold it shut. Replacing the lead restarts the wait. A late result still only fills extracted_guesses. Also keep the analysis status the upload page shows in one place, so a failed extra upload goes back to the latest status, including a ready result that arrived during the upload, rather than an older snapshot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The page opened Continue from its own timer. On a machine whose wall clock drifted against the browser's timers (about 8% on the WSL2 box used for end-to-end checks), it did so before the server had ended the wait, and the click was sent back to upload. Continue now opens when a status check reports the wait is over. The page's timer only matters if status checks keep failing: once it has run, a failed check opens Continue, so a broken connection still cannot hold the filer on the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
End-to-end check against a local server (real Tyler test sign-in). Screenshots: https://gist.github.com/nonprofittechy/80259c2d4c6db7e103bae9780597fce3
This run also found that the page's own timer could open Continue a few seconds before the server ended the wait (this machine's wall clock drifts about 8% against the browser's timers), which bounced the click back to upload. Fixed in ae263db: the server's status checks now decide, and the timer only matters while those checks are failing. 🤖 Generated with Claude Code |
…cted-amount # Conflicts: # efile_app/efile/tests/test_document_extractions.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a lead document is still being analyzed, the upload page used to enable “Preview your PDFs,” sending the filer into a redirect back to upload. Keep that link unavailable during upload and pending analysis, and show a short wait message. Complete analysis and the manual-review fallback both enable navigation.
If analysis has not finished after two minutes (
EXTRACTION_WAIT_LIMIT), the filer may continue and enter the case details by hand. The page says “This is taking longer than usual. You can continue and enter the case details yourself.” The server applies the limit in extraction review and reports the remaining wait to the page, so a worker that is down cannot strand the filer. The server decides when Continue opens. The page's own timer only matters if status checks keep failing, so a broken connection cannot strand the filer either. Replacing the lead restarts the wait. A result that arrives later only fills the suggested answers. Extracted amounts remain in analysis evidence and prefill the case-questions form; only a confirmed form submission writes the amount into filing and fee data.Preserve the preview destination and return-to-Review detour. An analysis response arriving during a new upload cannot enable navigation prematurely. A failed extra upload restores the latest analysis status, including a ready result that arrived during the upload.
Validation: upload/extraction and preview regression coverage, JavaScript pending/completion/failure/race/wait-limit checks, full Python and JS suites, and an end-to-end run against a local server with the extraction worker stopped and running (see the comment below).
Closes #281.
🤖 Generated with Claude Code
Late-analysis regression coverage
Worker regression tests verify that results arriving after manual continuation preserve both blank and previously confirmed amounts and leave the fee fingerprint unchanged. Case-question tests verify suggestion display without persistence, preservation of confirmed amounts and invalid submitted text, and saving the filer’s confirmed amount. The focused extraction, people-flow, and fee-quote suites pass (96 tests).