Repository navigation
Harden upload and logging boundaries and make extraction workers recoverable - #271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public legacy upload routes allowed anonymous S3 writes, application logs could contain credentials and filing contents, and obsolete extraction workers could overwrite newer analysis. This PR closes those routes and logging paths, updates vulnerable dependencies, and makes extraction attempts bounded and recoverable. YAML remains the authoring format with the existing in-memory cache.
Changes
STORAGES, and remove S3 bucket probes from ordinary operations.Validation
Rollout and scope
Stop old extraction workers before applying migration
0028_extraction_claim_leasesand starting the new web/worker image. Old workers do not honor claim tokens. Defaults are 600 seconds and 768 MiB of virtual address space per extraction child; validate against representative documents before increasing worker capacity.Review historical logs and rotate/revoke credentials confirmed to have been recorded. No production deployment or load test was performed. Upload quotas/cleanup, browser CSRF restoration, session-polling writes, and configuration compilation remain follow-up work. See
docs/developer-notes/security-hardening.mdfor details.