Repository navigation
Normalize CRLF line endings before splitting YAML blocks - #94
Merged
Merged
Conversation
Raw string callers such as the Weaver pass content with CRLF intact, so "---\r" separators did not match and the whole file was parsed as one block, producing a spurious "expected a single document" error at line 1. Refs SuffolkLITLab/docassemble-ALWeaver#1169 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the spurious parse error reported in SuffolkLITLab/docassemble-ALWeaver#1169.
Cause
find_errors_from_stringsplits blocks with^--- *$. When a file has CRLF line endings and is passed in as a raw string (as the Weaver does), each separator is---\r, which doesn't match. The whole file is then parsed as one block, and ruamel reportsexpected a single document in the stream ... but found another documentat line 1. The CLI never showed this becauseopen()in text mode already converts CRLF to LF.Reproduced with
docassemble-CLAGuardianship'sBond_MPC_801.yml(CRLF).Fix
Convert
\r\nand lone\rto\nat the start offind_errors_from_string, matching whatfind_errors()gets fromopen(). The line count doesn't change, so reported line numbers stay the same.Tests
test_crlf_document_separators_split_blocks, which checks that CRLF input gives the same findings as LF input. It fails without the fix.🤖 Generated with Claude Code