Repository navigation
Update background assembly instructions for saved completion gates - #635
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documentation incorrectly presents four seconds as the minimum configurable reload interval.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates background assembly guidance to use durable completion gates introduced by AssemblyLine PR #1113.
Changes:
- Documents completion variables, regeneration, customization, and troubleshooting.
- Updates combined-interview guidance to start background assembly before downloads.
| File | Description |
|---|---|
docs/components/AssemblyLine/background_assembly.md |
Reworks background assembly documentation. |
docs/authoring/combining_interviews.md |
Corrects combined-packet guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Clarify how to set the reload interval for assembly. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning to a completed interview after Celery expires its task result can leave users stuck on a waiting screen when interview order checks
.ready()directly. This updates the background assembly guide to use saved completion variables and explains how to regenerate documents after edits.The instructions assume AssemblyLine PR #1113 is merged and available. Merge this documentation alongside or after that implementation.
downloads_ready,downloads_with_docx_ready, andpreview_readythe standard interview-order pattern.Validation: both changed pages compiled with the site's Docusaurus MDX processor; all seven YAML/Python examples passed syntax checks;
git diff --checkpassed. The underlying workflow was verified on localhost with two-second task-result expiration in AssemblyLine PR #1113.