Delay popup for quick tab switching#7
Open
FichteFoll wants to merge 2 commits into
Open
Conversation
If only one ctrl+tab is intended and ctrl is quickly released, showing the popup for that brief period of time can be annoying. Instead, do what FireFox does and delay opening of the preview panel for a bit. If the key was released before the timeout expires, do not show the panel at all. Additionally, when ctrl+tab is pressed a second time we will force-open the panel because at this point the user clearly wants to do more than just quickly go to the previous tab. The only downside of this method is that now there is some "flicker" when the popup opens after the tab has already been focused.
This removes the flicker. It may make the tab switching feel less snappy because we are deliberately waiting a bit but both the tab and the hold version feel much better this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a quick test session, this does feel pretty nice. Testers wanted.
Closes #6.