fix(map): remove stale place ids from shared urls - #182
Open
techykaif wants to merge 1 commit into
Open
Conversation
Contributor
|
@techykaif is attempting to deploy a commit to the studentsuite Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes #149 by validating the place ID restored from the URL against the current place dataset.
If a shared link contains a deleted or renamed place ID, the map now drops that invalid focus instead of preserving a dead
?place=parameter.The existing URL synchronization then produces a clean shareable URL.
Type of change
Proof (required for new public places)
Not applicable. This PR does not add or modify any public places.
Checklist