feat: Make sk_gpu findable via cmake#32
Draft
Pandapip1 wants to merge 5 commits into
Draft
Conversation
13 tasks
Pandapip1
force-pushed
the
cmake-config
branch
8 times, most recently
from
November 7, 2025 07:41
aca9aa7 to
84a9d14
Compare
Pandapip1
marked this pull request as ready for review
November 7, 2025 07:45
Signed-off-by: Gavin John <gavinnjohn@gmail.com>
Signed-off-by: Gavin John <gavinnjohn@gmail.com>
Signed-off-by: Gavin John <gavinnjohn@gmail.com>
Signed-off-by: Gavin John <gavinnjohn@gmail.com>
That turns into an error on nix due to a compile flag Signed-off-by: Gavin John <gavinnjohn@gmail.com>
Pandapip1
force-pushed
the
cmake-config
branch
from
November 7, 2025 07:46
84a9d14 to
d9fd8f9
Compare
Author
|
I'm still fully testing everything (this is part of my nixpkgs packaging effort for future versions of stardust XR), but at the very least everything looks in order and it is successfully building and installing |
Pandapip1
marked this pull request as draft
November 7, 2025 09:47
Author
|
Some changes are still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it so that sk_gpu correctly installs its own targets, adds a cmake configuration target, and makes use of system packages where possible to avoid unnecessary network requests during build.