Skip to content

Fix build-macos failure by forcing spdlog to std::format - #2

Merged
BEASTSHRIRAM merged 2 commits into
mainfrom
copilot/fix-build-macos-job
Aug 26, 2026
Merged

Fix build-macos failure by forcing spdlog to std::format#2
BEASTSHRIRAM merged 2 commits into
mainfrom
copilot/fix-build-macos-job

Conversation

Copilot AI commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

build-macos failed in Actions job 98239026558 while compiling spdlog due to a consteval format-string error in the bundled fmt path on macOS clang. This change adjusts CMake configuration so spdlog uses the standard library formatting path instead.

  • Root cause

    • spdlog’s bundled fmt compile-time format-string path failed on macOS (fmt_helper.h consteval error).
  • Build configuration change

    • In glinx-core/CMakeLists.txt, set SPDLOG_USE_STD_FORMAT before FetchContent_MakeAvailable(spdlog) so dependency configuration is applied at fetch/configure time.
  • Scope

    • Single-file, surgical CMake change; no runtime API or behavior changes in Glinx codepaths.
FetchContent_Declare(
    spdlog
    GIT_REPOSITORY https://github.com/gabime/spdlog.git
    GIT_TAG v1.13.0
)
set(SPDLOG_USE_STD_FORMAT ON CACHE BOOL "Use std::format in spdlog" FORCE)
FetchContent_MakeAvailable(spdlog)

Co-authored-by: BEASTSHRIRAM <165943146+BEASTSHRIRAM@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job build-macos Fix build-macos failure by forcing spdlog to std::format Aug 26, 2026
Copilot AI requested a review from BEASTSHRIRAM August 26, 2026 16:38
@BEASTSHRIRAM
BEASTSHRIRAM marked this pull request as ready for review August 26, 2026 16:39
@BEASTSHRIRAM BEASTSHRIRAM added bug Something isn't working enhancement New feature or request labels Aug 26, 2026
@BEASTSHRIRAM
BEASTSHRIRAM merged commit 6fd013e into main Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants