Unblock build-linux by fixing C++ type visibility, nanobind array bindings, and benchmark gate logic - #1
Merged
Conversation
Co-authored-by: BEASTSHRIRAM <165943146+BEASTSHRIRAM@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'build-linux'
Unblock Aug 26, 2026
build-linux by fixing C++ type visibility, nanobind array bindings, and benchmark gate logic
BEASTSHRIRAM
marked this pull request as ready for review
August 26, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-linuxfailed in CI due to compile-time type resolution errors in the runtime header and invalid nanobind bindings for fixed-size char arrays. The job was also vulnerable to false benchmark failures from chrono type mismatch and overly rigid throughput pass criteria.Header dependency restoration (
ipc.hpp)driver.hppinclude soDriverandjsonare visible whereGlinxRuntimeis declared.json does not name a type/Driver was not declarederrors.Python binding compatibility (
bindings/python.cpp).def_rwonchar[N]members with explicit string properties (def_prop_rw) forsource_idandprotocol.Shared module linkability (
CMakeLists.txt)CMAKE_POSITION_INDEPENDENT_CODE ON) so static deps can be linked into_glinx_coreon Linux.Throughput benchmark correctness (
throughput_bench.cpp)duration<double>tohigh_resolution_clock::durationbeforetime_point +=.10000) and added practical scheduler tolerance.