Fix error processing GeoResult#3124
Merged
Merged
Conversation
philon-msft
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigate and fix #3123; PEBKAC - conversion error with
ReadString()vsReadRedisValue()during the v3 read conversion (0180afa).OK; so: I've added more notes here in /docs/exp/StringToRedisValue.md - no point me duplicating that all here. Short version:
ReadString()was used whereReadRedisValue()was wanted. I have added a trap to prevent this in the future; if I run the build with the original code, I now see:Only
DEBUGbuilds are impacted - this trap does not exist in the shipped dll.Every other usage was a false-positive; I've fixed those by using
.AsRedisValue(), but there is no semantic change - just being explicit rather than implicit to tell the build we know what we're doing.