Skip to content

Fix error processing GeoResult#3124

Merged
mgravell merged 9 commits into
mainfrom
marc/georesult
Jul 10, 2026
Merged

Fix error processing GeoResult#3124
mgravell merged 9 commits into
mainfrom
marc/georesult

Conversation

@mgravell

@mgravell mgravell commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Investigate and fix #3123; PEBKAC - conversion error with ReadString() vs ReadRedisValue() during the v3 read conversion (0180afa).

OK; so: I've added more notes here in /docs/exp/StringToRedisValue.md - no point me duplicating that all here. Short version: ReadString() was used where ReadRedisValue() was wanted. I have added a trap to prevent this in the future; if I run the build with the original code, I now see:

ResultProcessor.cs(1904, 48): [StringToRedisValue] 'StackExchange.Redis.RedisValue.implicit operator StackExchange.Redis.RedisValue(string?)' is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed. (https://stackexchange.github.io/StackExchange.Redis/exp/StringToRedisValue)

ResultProcessor.cs(1945, 44): [StringToRedisValue] 'StackExchange.Redis.RedisValue.implicit operator StackExchange.Redis.RedisValue(string?)' is for evaluation purposes only and is subject to change or removal in future updates. Suppress this diagnostic to proceed. (https://stackexchange.github.io/StackExchange.Redis/exp/StringToRedisValue)

Only DEBUG builds are impacted - this trap does not exist in the shipped dll.

Every other usage was a false-positive; I've fixed those by using .AsRedisValue(), but there is no semantic change - just being explicit rather than implicit to tell the build we know what we're doing.

@mgravell mgravell changed the title investigate and fix #3123 Fix error processing GeoResult Jul 9, 2026
@mgravell mgravell requested a review from philon-msft July 9, 2026 18:58
@mgravell mgravell merged commit afcc0dc into main Jul 10, 2026
6 of 7 checks passed
@mgravell mgravell deleted the marc/georesult branch July 10, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GeoRadiusResult.Member no longer byte[] in version 3.x on

2 participants