Skip to content

Support custom namespaces, preserve button query params, clarify README - #50

Merged
andreibondarev merged 1 commit into
mainfrom
fix-open-issues
Oct 22, 2026
Merged

andreibondarev merged 1 commit into
mainfrom
fix-open-issues

Conversation

@andreibondarev

Copy link
Copy Markdown
Member

Closes #11, closes #12, closes #42, closes #45.

Changes

Notes

Testing

  • bundle exec rspec: 9 examples, 0 failures (adds a custom-namespace route spec)
  • JS click handler checked in Node against a stubbed DOM: existing query params are kept and repeated clicks don't duplicate ids. Not tested in a real browser.

- Add AdministrateBatchActions.namespace (symbol or array, default :admin)
  so batch action routes are generated for controllers outside
  app/controllers/admin (#11)
- Build the batch action URL with the URL API so existing query params
  are kept and repeated clicks don't append duplicate ids (#45)
- Clarify that the button helper's first argument is a string label (#12)
- Update README/CHANGELOG for the route scheme introduced in #47/#49,
  which fixed the missing admin namespace (#42)
@andreibondarev
andreibondarev merged commit 88f2f76 into main Oct 22, 2026
1 check passed
@andreibondarev
andreibondarev deleted the fix-open-issues branch October 22, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant