Skip to content

Update dependency commons-logging:commons-logging to v99 - #6510

Merged
vdiez merged 1 commit into
masterfrom
renovate/major-commons-logging-commons-logging
Nov 12, 2026
Merged

vdiez merged 1 commit into
masterfrom
renovate/major-commons-logging-commons-logging

Conversation

@renovate

@renovate renovate Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
commons-logging:commons-logging 1.4.0 → 99.0-does-not-exist age confidence

Configuration

📅 Schedule: (in timezone CET)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added the dependencies Pull requests that update a dependency file label Nov 12, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Renovate Jira issue ID: SONARJAVA-7331

@gitar-bot

gitar-bot Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Code Review ⚠️ Changes requested 🟡 Medium risk 0 closed / 1 findings

Changing commons-logging to the nonexistent 99.0-does-not-exist version could prevent Maven from resolving the dependency and break builds.

Bumps commons-logging:commons-logging from 1.4.0 to 99.0-does-not-exist, which is an empty placeholder jar rather than a real release. Because the root <dependencyManagement> pins it, every commons-logging dependency in the reactor, including the provided one in sonar-java-plugin/pom.xml, would resolve to an artifact with no classes, so any code loading org.apache.commons.logging.LogFactory would fail with NoClassDefFoundError. Changes requested: close this PR, keep 1.4.0 in pom.xml, and add a Renovate rule to stop proposing this pseudo-version.

⚠️ Bug: 99.0-does-not-exist is an empty stub jar, not a commons-logging release

📄 pom.xml:298-302

commons-logging:commons-logging:99.0-does-not-exist is not a real release. It is the empty placeholder jar from the linked "no more commons-logging" blog post. People use it to keep commons-logging off the classpath when they bridge to SLF4J. Renovate read the version string as a major upgrade. This entry is in the root <dependencyManagement>, so every commons-logging dependency in the reactor gets forced to the empty jar, transitive ones included. That covers the provided dependency in sonar-java-plugin/pom.xml, which is also on the test classpath. Any code or test that loads org.apache.commons.logging.LogFactory would then fail with NoClassDefFoundError. The repo has no jcl-over-slf4j bridge to provide those classes. This PR swaps a working 1.4.0 library for an artifact with no classes in it. Close the PR and keep 1.4.0. Add a Renovate rule so the bot stops proposing this pseudo-version.

Keep the real release in pom.xml
<version>1.4.0</version>
Renovate packageRule to ignore the stub version (renovate.json)
{
  "packageRules": [
    {
      "matchPackageNames": ["commons-logging:commons-logging"],
      "allowedVersions": "<99"
    }
  ]
}
🤖 Prompt for agents
Code Review: Bumps `commons-logging:commons-logging` from `1.4.0` to `99.0-does-not-exist`, which is an empty placeholder jar rather than a real release. Because the root `<dependencyManagement>` pins it, every commons-logging dependency in the reactor, including the `provided` one in `sonar-java-plugin/pom.xml`, would resolve to an artifact with no classes, so any code loading `org.apache.commons.logging.LogFactory` would fail with `NoClassDefFoundError`. Changes requested: close this PR, keep `1.4.0` in `pom.xml`, and add a Renovate rule to stop proposing this pseudo-version.

1. ⚠️ Bug: 99.0-does-not-exist is an empty stub jar, not a commons-logging release
   Files: pom.xml:298-302

   `commons-logging:commons-logging:99.0-does-not-exist` is not a real release. It is the empty placeholder jar from the linked "no more commons-logging" blog post. People use it to keep commons-logging off the classpath when they bridge to SLF4J. Renovate read the version string as a major upgrade. This entry is in the root `<dependencyManagement>`, so every commons-logging dependency in the reactor gets forced to the empty jar, transitive ones included. That covers the `provided` dependency in `sonar-java-plugin/pom.xml`, which is also on the test classpath. Any code or test that loads `org.apache.commons.logging.LogFactory` would then fail with `NoClassDefFoundError`. The repo has no `jcl-over-slf4j` bridge to provide those classes. This PR swaps a working 1.4.0 library for an artifact with no classes in it. Close the PR and keep 1.4.0. Add a Renovate rule so the bot stops proposing this pseudo-version.

   Fix (Keep the real release in pom.xml):
   <version>1.4.0</version>

   Fix (Renovate packageRule to ignore the stub version (renovate.json)):
   {
     "packageRules": [
       {
         "matchPackageNames": ["commons-logging:commons-logging"],
         "allowedVersions": "<99"
       }
     ]
   }

Verification Rules 2/2 met Repos 5 inspected

Functional validation No results

Rules 2 passed 1 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact Repos 5 inspected
Cross-repo 5 repositories inspected 0 open impacts

SonarSource/sonarqube Inspected
SonarSource/sonarlint-eclipse Inspected
SonarSource/sonarlint-intellij Inspected
SonarSource/sonarlint-vscode Inspected
SonarSource/sonar-java-symbolic-execution Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change the behavior for this request:

Auto-apply Compact Unblock
gitar auto-apply:on         
gitar display:verbose         
gitar unblock         

Was this helpful? React with 👍 / 👎 | Gitar

Comment thread pom.xml
Comment on lines 298 to 302
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>1.4.0</version>
<version>99.0-does-not-exist</version>
</dependency>

@gitar-bot gitar-bot Bot Nov 12, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Bug: 99.0-does-not-exist is an empty stub jar, not a commons-logging release

commons-logging:commons-logging:99.0-does-not-exist is not a real release. It is the empty placeholder jar from the linked "no more commons-logging" blog post. People use it to keep commons-logging off the classpath when they bridge to SLF4J. Renovate read the version string as a major upgrade. This entry is in the root <dependencyManagement>, so every commons-logging dependency in the reactor gets forced to the empty jar, transitive ones included. That covers the provided dependency in sonar-java-plugin/pom.xml, which is also on the test classpath. Any code or test that loads org.apache.commons.logging.LogFactory would then fail with NoClassDefFoundError. The repo has no jcl-over-slf4j bridge to provide those classes. This PR swaps a working 1.4.0 library for an artifact with no classes in it. Close the PR and keep 1.4.0. Add a Renovate rule so the bot stops proposing this pseudo-version.

Was this helpful? React with 👍 / 👎

@sonarqube-next

Copy link
Copy Markdown
Contributor

@vdiez vdiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: Renovate dependency update.

@vdiez
vdiez merged commit 213bae3 into master Nov 12, 2026
22 checks passed
@vdiez
vdiez deleted the renovate/major-commons-logging-commons-logging branch November 12, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant