Repository navigation
Simplify the parser interface - #6503
aurelien-coet-sonarsource wants to merge 3 commits into
Conversation
f8e2e46 to
dcc6ef9
Compare
dcc6ef9 to
57223e9
Compare
c8db305 to
29f2345
Compare
leonardo-pilastri-sonarsource
left a comment
There was a problem hiding this comment.
Nice 💃
29f2345 to
5006a8c
Compare
Code Review ✅ Approved 🔴 High risk 5 closed / 5 findingsReplacing JParserConfig and moving parser/semantic types breaks public APIs, which could disrupt custom rules compiled against the previous interfaces. Simplifies the parser interface by removing the unused parse overload in ✅ 5 closed✅ Quality: 8.47 notes still say multi-file parse keeps binary compatibility
✅ Cross-Repo: SE repo JParserTestUtils stops compiling: JParserConfig/astParser removed
✅ Cross-Repo: SE repo JParserTestUtils loses its 3-arg parse migration path
✅ Cross-PR: #6459's useJdkReleaseOption flag has no parameter after JParserConfig removal
✅ Quality: Unused slf4j imports left after removing the LOG field
Verification Rules 1/1 met PRs 2 inspectedFunctional validation No results Rules 1 passed 3 not applicable
Broader impact PRs 2 inspectedCross-PR 2 PRs inspected 0 open impacts
Auto-approval Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|




Summary by Gitar
JParserConfigwith aJParserinterface, created viaJParser.Mode#create.JParseResultto carry parse results to callbacks.org.sonar.java.jdt(JDTParser,JDTAstConverter,JDTSema).Symbol#annotationElementDefaultValuefor annotation element defaults.documentation.md.org.sonar.java.jdtand updated helpers to useJParser.This will update automatically on new commits.