Repository navigation
Conversation
Pass an empty classpath for batch and single-file parsing, removing dependency, compiled-class and runtime JDK provisioning. Keep the built-in semsitter JDK fallback. Upgrade Develocity to 2.6.1 so frontend compilation succeeds with Maven 3.10.0.
|
/pvf |
Use java.home/lib/modules for batch and single-file parsing while keeping project dependencies and compiled classes excluded.
Code Review ✅ Approved🟡 Medium risk · Restricting SemSitter’s classpath to JDK modules omits project dependencies, which could alter type resolution and produce incomplete or changed findings. Experimental change that supplies only the running JDK's Verification Rules 2/2 met Repos 5 inspectedFunctional validation No results Rules 2 passed 1 not applicable
Broader impact Repos 5 inspectedCross-repo 5 repositories inspected 0 open impacts
Auto-approval Not enabledFor more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
📊 Performance Validation complete Projects with unexpected PVF results:
|
SONARJAVA-7236: Compare sem-sitter findings with only the running JDK supplied as its external classpath.
Both batch and single-file parsing send
${java.home}/lib/modulesto the bridge. Project dependency JARs and compiled-class directories are excluded. Sem-sitter retains its built-in JDK fallback.This draft is based on the sem-sitter PoC branch in #6415 and is intended for the comparison experiment. The classpath is used by bridge type lookups; the PoC does not explicitly forward it into its semantic graph scan settings.
The Develocity extension is also updated from 1.22.2 to 2.6.1 to fix its startup failure with local Maven 3.10.0.
Validation: frontend and prerequisite modules compile successfully with Java 21 and Maven 3.10.0 (
mvn -B -ntp -o -pl java-frontend -am -Dmaven.test.skip=true -Dlicense.skip=true -Dscan=false compile). Diff whitespace checks pass. Rule tests and ruling have not been run locally.