Skip to content

RC-354 Pin core-languages-tooling-public actions to the current master commit - #6457

Open
romainbrenguier wants to merge 2 commits into
masterfrom
romain/rc-354-pin-core-languages-tooling
Open

romainbrenguier wants to merge 2 commits into
masterfrom
romain/rc-354-pin-core-languages-tooling

Conversation

@romainbrenguier

Copy link
Copy Markdown
Contributor

Summary

  • Pin all existing SonarSource/core-languages-tooling-public GitHub Action references to a04d15c9fe09880db6870b01875e184ed57ca242, the current master HEAD on November 2, 2026.
  • Keep the current tooling behavior stable before RC-354: Expectation update tool improvements core-languages-tooling-public#85 changes ruling artifact uploads to accept SARIF files only.
  • This is a protective pin, not adoption of the new artifact format. Analyzers can migrate separately and update their ruling actions together when ready.

Validation

  • git diff --check passes.
  • Automated comparison confirms that only action versions change (and an outdated snapshot-date comment is removed where applicable).
  • Analyzer builds and ruling tests are not run: no analyzer code or artifact-upload behavior changes in this PR.

@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

RC-354

Comment thread .github/workflows/build.yml Resolved
@sonarqube-next

sonarqube-next Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@romainbrenguier
romainbrenguier marked this pull request as ready for review November 2, 2026 14:13
@romainbrenguier

Copy link
Copy Markdown
Contributor Author

@Gitar we should pin to v1 instead of master or a specific commit

Co-authored-by: Romain Brenguier <11854194+romainbrenguier@users.noreply.github.com>
@gitar-bot

gitar-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 🟡 Medium risk 1 closed / 1 findings

Changing four GitHub Action references from master to v1 could alter ruling, artifact, or performance-validation automation if the tag differs.

Pins all SonarSource/core-languages-tooling-public action references to commit a04d15c9fe09880db6870b01875e184ed57ca242 to keep ruling tooling stable ahead of the SARIF-only artifact change. Resolved the shallow-pin issue where pinned actions still called sibling actions at @master, so the pin now covers nested references too.

✅ 1 closed
✅ Edge Case: Pin is shallow: pinned actions still call sibling actions @master

📄 .github/workflows/build.yml:194 📄 .github/workflows/pvf-comment.yml:34
The SHA pin only freezes the top-level action files. At a04d15c, ruling-update-and-notify/action.yml (line 137) calls SonarSource/core-languages-tooling-public/ruling-diff-comment@master, and pvf-trigger/action.yml (line 53) calls pvf-comment@master. Those nested steps keep resolving against the live master. That means the Update ruling and notify job in build.yml and the PVF trigger in pvf-comment.yml can still change behavior when upstream changes, which contradicts the PR's goal of keeping tooling behavior stable. PR #85 doesn't touch ruling-diff-comment or pvf-comment (see its file list), so the SARIF change itself is covered. Any later change to those two nested actions is not. To get a full pin, the upstream composite actions would need to reference their siblings through ${{ github.action_path }}-relative local paths or pinned SHAs. Otherwise, the PR description should say this pin is partial.

Verification Rules 1/3 met PRs 4 inspected
Rules 2 failed 1 passed 1 not applicable

❌ Approved GitHub Actions runners - Repo state still uses retired sonar-xs-public labels (e.g. build.yml:484, releasability.yaml, cleanup-cache.yml); migrate to approved labels such as sonar-xs or github-ubuntu-latest-s per https://xtranet-sonarsource.atlassian.net/wiki/spaces/Platform/pages/3694231566/GitHub+Actions+Runners+-+GitHub (pre-existing, not changed by this PR).
❌ Repository license compliance - LICENSE.txt contains SONAR Source-Available License v1.0 text, but the central exception for sonar-java requires LGPL-3.0 at LICENSE.txt and no local override exists (pre-existing, not changed by this PR).
✅ Internal artifact registries

Functional validation No results

Broader impact PRs 4 inspected
Cross-PR 4 PRs inspected 0 open impacts

PR 85: RC-354: Expectation update tool improvements Inspected
PR 6445: RC-451 Migrate Java ruling expectations to SARIF Inspected
PR 6418: RC-353 Test Sarif diff Inspected
PR 6429: Test ruling-diff action across all ruling projects Inspected

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

Copy link
Copy Markdown
Contributor

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants