RC-350 Unify ruling expectation file locations

[romainbrenguier]

Summary

• Move ruling expectation files from its/ruling/src/test/resources/<project>/ to its/ruling/src/test/resources/expected/java/<project>/
• Update JavaRulingTest to reference the new path

Test plan

• Ruling tests pass on CI with the new file locations

🤖 Generated with Claude Code

[hashicorp-vault-sonar-prod]

RC-350

[gitar-bot]

⚠️ Bug: CI ruling-root inputs still point at the old expectation root

ruling-update-and-notify copies the merged actual_* artifacts straight into ruling-root (cp -rv "$TEMP_DIR"/* "${ruling-root}/" in SonarSource/core-languages-tooling-public/ruling-update-and-notify/action.yml:302), and the artifacts are laid out as <project>/java-SXXXX.json. With ruling-root: 'its/ruling/src/test/resources' unchanged, the auto-update job will recreate the pre-PR its/ruling/src/test/resources/<project>/ tree instead of updating expected/java/<project>/, so the generated update PR never fixes the ruling failure that JavaRulingTest reads from src/test/resources/expected/java. Likewise ruling-diff-comment parses each changed path with parse_ruling_relative_path, which requires exactly <project>/<repo>-<rule>.json after stripping ruling-root; the new paths yield expected/java/<project>/java-SXXXX.json (4 parts), so every ruling file is dropped with "Skipping unrecognized ruling path" and no diff comment is ever posted again. Point both ruling-root inputs at its/ruling/src/test/resources/expected/java.

build.yml: point the auto-update action at the new expectation root (apply the same change to ruling-diff-comment.yml:56):

ruling-root: 'its/ruling/src/test/resources/expected/java'

• Apply fix

_{Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review ⚠️ Changes requested 0 resolved / 1 findings

Refactors ruling expectation file locations to its/ruling/src/test/resources/expected/java/<project>/ but CI inputs still reference the old root. The ruling-root parameters in the auto-update and diff-comment jobs must be updated to its/ruling/src/test/resources/expected/java to prevent the ruling-update workflow from recreating the pre-PR directory structure and to ensure diff comments are generated correctly.

⚠️ Bug: CI ruling-root inputs still point at the old expectation root

📄 its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:160

ruling-update-and-notify copies the merged actual_* artifacts straight into ruling-root (cp -rv "$TEMP_DIR"/* "${ruling-root}/" in SonarSource/core-languages-tooling-public/ruling-update-and-notify/action.yml:302), and the artifacts are laid out as <project>/java-SXXXX.json. With ruling-root: 'its/ruling/src/test/resources' unchanged, the auto-update job will recreate the pre-PR its/ruling/src/test/resources/<project>/ tree instead of updating expected/java/<project>/, so the generated update PR never fixes the ruling failure that JavaRulingTest reads from src/test/resources/expected/java. Likewise ruling-diff-comment parses each changed path with parse_ruling_relative_path, which requires exactly <project>/<repo>-<rule>.json after stripping ruling-root; the new paths yield expected/java/<project>/java-SXXXX.json (4 parts), so every ruling file is dropped with "Skipping unrecognized ruling path" and no diff comment is ever posted again. Point both ruling-root inputs at its/ruling/src/test/resources/expected/java.

build.yml: point the auto-update action at the new expectation root (apply the same change to ruling-diff-comment.yml:56)

ruling-root: 'its/ruling/src/test/resources/expected/java'

🤖 Prompt for agents

Code Review: Refactors ruling expectation file locations to `its/ruling/src/test/resources/expected/java/<project>/` but CI inputs still reference the old root. The `ruling-root` parameters in the auto-update and diff-comment jobs must be updated to `its/ruling/src/test/resources/expected/java` to prevent the ruling-update workflow from recreating the pre-PR directory structure and to ensure diff comments are generated correctly.

1. ⚠️ Bug: CI ruling-root inputs still point at the old expectation root
   Files: its/ruling/src/test/java/org/sonar/java/it/JavaRulingTest.java:160

   `ruling-update-and-notify` copies the merged `actual_*` artifacts straight into `ruling-root` (`cp -rv "$TEMP_DIR"/* "${ruling-root}/"` in SonarSource/core-languages-tooling-public/ruling-update-and-notify/action.yml:302), and the artifacts are laid out as `<project>/java-SXXXX.json`. With `ruling-root: 'its/ruling/src/test/resources'` unchanged, the auto-update job will recreate the pre-PR `its/ruling/src/test/resources/<project>/` tree instead of updating `expected/java/<project>/`, so the generated update PR never fixes the ruling failure that `JavaRulingTest` reads from `src/test/resources/expected/java`. Likewise `ruling-diff-comment` parses each changed path with `parse_ruling_relative_path`, which requires exactly `<project>/<repo>-<rule>.json` after stripping `ruling-root`; the new paths yield `expected/java/<project>/java-SXXXX.json` (4 parts), so every ruling file is dropped with "Skipping unrecognized ruling path" and no diff comment is ever posted again. Point both `ruling-root` inputs at `its/ruling/src/test/resources/expected/java`.

   Fix (build.yml: point the auto-update action at the new expectation root (apply the same change to ruling-diff-comment.yml:56)):
   ruling-root: 'its/ruling/src/test/resources/expected/java'

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.
Unblock → Override a blocking verdict and allow merging.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact	Unblock
gitar auto-apply:on	gitar display:verbose	gitar unblock

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube