Extract inline Mockito mock creations#5823
Merged
Merged
Conversation
Extract mocks passed directly to thenReturn into named local variables across the affected tests. This satisfies S9016 and preserves the existing stubbing behavior while allowing Mockito to validate unfinished stubbing correctly. These five findings were the only open issues causing the SonarQube Next quality gate to fail.
mostafa-mohammed-sonarsource
force-pushed
the
mm/fix-mock-creation
branch
from
July 20, 2026 11:56
a9458ce to
9f99e7b
Compare
mostafa-mohammed-sonarsource
changed the title
Code Review ✅ ApprovedExtracts inline Mockito mock creations into named local variables to resolve five java:S9016 violations. Existing test behavior is preserved, and no further issues were identified. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
mostafa-mohammed-sonarsource
marked this pull request as ready for review
July 20, 2026 11:57
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thenReturninto named local variablesjava:S9016issues failing the SonarQube Next quality gateTesting
CI will verify the affected test suites and SonarQube quality gate.