Repository navigation
fix(scoring)!: count changed group keys in changed_key_count - #211
Merged
Merged
Conversation
SharedNodeDiagnostics::changed_key_count was incremented together with update_count, one per row-changing notification, so it duplicated it. A new GroupedOperator trait reports how many group keys an operator's last insert or retract changed: GroupNode records the size of the changed-group set it already builds, and ComplementNode and JoinNode over a grouped input report that input's count. Each notification now adds that count, so one notification can add several keys, or none when only a complemented or joined node's non-grouped side changed. Closes #210. BREAKING CHANGE: SharedOperatorTerminal requires its operator to implement GroupedOperator, and changed_key_count now sums changed group keys instead of counting row-changing notifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #210. Base
main@36021382, one commit40e95abc.New
GroupedOperator<S>: Operator<S>withchanged_group_count():GroupNoderecords its changed-group set size;ComplementNodeandJoinNodeover a grouped input delegate.SharedOperatorTerminaladds it per notification. BREAKING footer (terminal bound and the field's meaning).Tests: projected two-bucket projection (one notification, two keys); complemented and grouped-join nodes (non-grouped-side notification: rows change, zero keys; grouped-side: one key per group). Mutation restoring the old one-per-notification increment fails the complemented and projected tests.
Gate (fmt, clippy, doc-names file-length facade-reachability public-api deps, rustdoc, examples, workspace all-feature tests, doctests): EXIT 0, 1588 passed, 0 failed, 71 result lines.