Repository navigation
Humanreadable improvement fixes and refresh for release - #788
Merged
Merged
Conversation
SharonStrats
commented
Oct 31, 2026
SharonStrats
commented
Contributor
- restore pdf rendering, use chrome viewer
- humanreadable panes on mobile, no scroll fit the whole page
- desktop - extend the page
- Support JSON - no special treatment now Prompt: pdf is not appearing - chrome blocked it worked in main branch please investigate and fix
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved security issues let shared HTML previews read private same-origin files and unsandboxed SVG previews access the parent application and its storage.
5 open issues
What changed in this PR
This PR updates human-readable previews to restore native PDF viewing, improve desktop and mobile sizing, and support JSON and signed-in Dokieli sessions.
Changes:
- Adjust iframe sandboxing for browser viewers and display JSON as plain text.
- Add preview height reporting and revise responsive layouts.
- Extend Dokieli’s session bridge and request handling, with corresponding unit tests.
| File | Description |
|---|---|
test/unit/humanReadablePane.test.ts |
Tests JSON rendering, PDF sandbox behavior, and Dokieli bridge changes. |
src/humanReadablePane.ts |
Updates preview rendering, automatic sizing, and Dokieli session integration. |
src/humanReadablePane.css |
Revises pane sizing, scrolling, and mobile layout rules. |
Review effort: Balanced
- restore pdf rendering, use chrome viewer - humanreadable panes on mobile, no scroll fit the whole page - desktop - extend the page - Support JSON - no special treatment now Prompt: pdf is not appearing - chrome blocked it worked in main branch please investigate and fix Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
force-pushed
the
feat/humanreadable-improvements
branch
from
October 31, 2026 22:14
1ed08e7 to
87d55fa
Compare
…@5.0.2-5 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.